* [PATCH] clk: clkdev: fix format security.
@ 2025-07-29 4:56 chalianis1
2025-07-31 9:03 ` Ahmad Fatoum
2025-08-05 7:42 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: chalianis1 @ 2025-07-29 4:56 UTC (permalink / raw)
To: s.hauer; +Cc: barebox, Chali Anis
From: Chali Anis <chalianis1@gmail.com>
not a string literal and no format
arguments [-Werror=format-security]
Fixes: dfcdce8eec30 ("arm: add common clkdev")
Signed-off-by: Chali Anis <chalianis1@gmail.com>
---
drivers/clk/clkdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index dbe998b6af35..1ce2eb95b8f9 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
if (IS_ERR(r))
return PTR_ERR(r);
- l = clkdev_alloc(r, alias, alias_dev_name);
+ l = clkdev_alloc(r, alias, "%s", alias_dev_name);
clk_put(r);
if (!l)
return -ENODEV;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: clkdev: fix format security.
2025-07-29 4:56 [PATCH] clk: clkdev: fix format security chalianis1
@ 2025-07-31 9:03 ` Ahmad Fatoum
2025-08-05 7:42 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2025-07-31 9:03 UTC (permalink / raw)
To: chalianis1, s.hauer; +Cc: barebox
Hi,
On 7/29/25 06:56, chalianis1@gmail.com wrote:
> From: Chali Anis <chalianis1@gmail.com>
>
> not a string literal and no format
> arguments [-Werror=format-security]
>
> Fixes: dfcdce8eec30 ("arm: add common clkdev")
> Signed-off-by: Chali Anis <chalianis1@gmail.com>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
Ahmad
> ---
> drivers/clk/clkdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
> index dbe998b6af35..1ce2eb95b8f9 100644
> --- a/drivers/clk/clkdev.c
> +++ b/drivers/clk/clkdev.c
> @@ -273,7 +273,7 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
> if (IS_ERR(r))
> return PTR_ERR(r);
>
> - l = clkdev_alloc(r, alias, alias_dev_name);
> + l = clkdev_alloc(r, alias, "%s", alias_dev_name);
> clk_put(r);
> if (!l)
> return -ENODEV;
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] clk: clkdev: fix format security.
2025-07-29 4:56 [PATCH] clk: clkdev: fix format security chalianis1
2025-07-31 9:03 ` Ahmad Fatoum
@ 2025-08-05 7:42 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-08-05 7:42 UTC (permalink / raw)
To: chalianis1; +Cc: barebox
On Tue, 29 Jul 2025 00:56:07 -0400, chalianis1@gmail.com wrote:
> not a string literal and no format
> arguments [-Werror=format-security]
>
>
Applied, thanks!
[1/1] clk: clkdev: fix format security.
https://git.pengutronix.de/cgit/barebox/commit/?id=ffeeae51a5cf (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-05 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-29 4:56 [PATCH] clk: clkdev: fix format security chalianis1
2025-07-31 9:03 ` Ahmad Fatoum
2025-08-05 7:42 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox