[PATCH] ARM: riotboard: add habv4-imx6-gencsf.h to flash header

[PATCH] ARM: riotboard: add habv4-imx6-gencsf.h to flash header

[Bastian Krause]

The header is necessary to add CSF data for signed barebox images in
case HABV4_IMAGE_SIGNED=y is set. It should not hurt otherwise.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 .../embest-riotboard/flash-header-embest-riotboard.imxcfg       | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
index 5464e2461d0..1f27163417f 100644
--- a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
+++ b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
@@ -66,3 +66,5 @@ wm 32 MX6_MMDC_P0_MPODTCTRL 0x00011117
 wm 32 MX6_MMDC_P0_MDPDC 0x00025565
 wm 32 MX6_MMDC_P0_MAPSR 0x00011006
 wm 32 MX6_MMDC_P0_MDSCR 0x00000000
+
+#include <mach/imx/habv4-imx6-gencsf.h>
-- 
2.39.5

Re: [PATCH] ARM: riotboard: add habv4-imx6-gencsf.h to flash header

[Ahmad Fatoum]

Hi Bastian,

On 7/10/25 11:06, Bastian Krause wrote:
> The header is necessary to add CSF data for signed barebox images in
> case HABV4_IMAGE_SIGNED=y is set. It should not hurt otherwise.

If it doesn't hurt, what do you think of having the build system include
it everywhere unconditionally?

> Signed-off-by: Bastian Krause <bst@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Cheers,
Ahmad

> ---
>  .../embest-riotboard/flash-header-embest-riotboard.imxcfg       | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
> index 5464e2461d0..1f27163417f 100644
> --- a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
> +++ b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
> @@ -66,3 +66,5 @@ wm 32 MX6_MMDC_P0_MPODTCTRL 0x00011117
>  wm 32 MX6_MMDC_P0_MDPDC 0x00025565
>  wm 32 MX6_MMDC_P0_MAPSR 0x00011006
>  wm 32 MX6_MMDC_P0_MDSCR 0x00000000
> +
> +#include <mach/imx/habv4-imx6-gencsf.h>

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

Re: [PATCH] ARM: riotboard: add habv4-imx6-gencsf.h to flash header

[Bastian Krause]

On 7/31/25 11:08 AM, Ahmad Fatoum wrote:
> Hi Bastian,
> 
> On 7/10/25 11:06, Bastian Krause wrote:
>> The header is necessary to add CSF data for signed barebox images in
>> case HABV4_IMAGE_SIGNED=y is set. It should not hurt otherwise.
> 
> If it doesn't hurt, what do you think of having the build system include
> it everywhere unconditionally?

That's exactly what I thought when I stumbled upon the missing include,
but I did not look into it.

> 
>> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> 
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Thanks!

Regards,
Bastian

> 
> Cheers,
> Ahmad
> 
>> ---
>>   .../embest-riotboard/flash-header-embest-riotboard.imxcfg       | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
>> index 5464e2461d0..1f27163417f 100644
>> --- a/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
>> +++ b/arch/arm/boards/embest-riotboard/flash-header-embest-riotboard.imxcfg
>> @@ -66,3 +66,5 @@ wm 32 MX6_MMDC_P0_MPODTCTRL 0x00011117
>>   wm 32 MX6_MMDC_P0_MDPDC 0x00025565
>>   wm 32 MX6_MMDC_P0_MAPSR 0x00011006
>>   wm 32 MX6_MMDC_P0_MDSCR 0x00000000
>> +
>> +#include <mach/imx/habv4-imx6-gencsf.h>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] ARM: riotboard: add habv4-imx6-gencsf.h to flash header

[Sascha Hauer]

On Thu, 10 Jul 2025 11:06:44 +0200, Bastian Krause wrote:
> The header is necessary to add CSF data for signed barebox images in
> case HABV4_IMAGE_SIGNED=y is set. It should not hurt otherwise.
> 
> 

Applied, thanks!

[1/1] ARM: riotboard: add habv4-imx6-gencsf.h to flash header
      https://git.pengutronix.de/cgit/barebox/commit/?id=957a9aa86e6e (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>