[PATCH] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after

[PATCH] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after

[Ahmad Fatoum]

The current logic inside MAKEALL is flawed: We source an ARM64 config
with CROSS_COMPILE=${CROSS_COMPILE_arm} and hope that CONFIG_ARM64
results, so we can grep for it in the .config despite it missing in the
defconfig.

Replace this by looking for CONFIG_64BIT instead in the defconfig
directly. This symbol seems to be there for all ARM64 configs we have
and if this ceases, CI will let us know.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 MAKEALL | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index d47f0204f1f1..abce297a9bf8 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -135,13 +135,10 @@ do_build_defconfig() {
 	[ -n "$logdir" ] && mkdir -p "${logdir}/${defconfig}"
 
 	MAKE="make -j${JOBS} ARCH=${arch} O=${BUILDDIR}"
-	${MAKE} ${defconfig} &>/dev/null
 
-	if [ ${arch} = "arm" ]; then
-		grep -q "CONFIG_ARM64=y" ${BUILDDIR}/.config
-		if [ $? = 0 ]; then
-			arch=arm64
-		fi
+	grep -q "CONFIG_64BIT=y" arch/${arch}/configs/${defconfig}
+	if [ $? = 0 ]; then
+		arch=arm64
 	fi
 
 	tmp=$(echo "${defconfig}" | tr - _)
-- 
2.47.3

Re: [PATCH] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after

[Sascha Hauer]

On Tue, 30 Sep 2025 10:53:58 +0200, Ahmad Fatoum wrote:
> The current logic inside MAKEALL is flawed: We source an ARM64 config
> with CROSS_COMPILE=${CROSS_COMPILE_arm} and hope that CONFIG_ARM64
> results, so we can grep for it in the .config despite it missing in the
> defconfig.
> 
> Replace this by looking for CONFIG_64BIT instead in the defconfig
> directly. This symbol seems to be there for all ARM64 configs we have
> and if this ceases, CI will let us know.
> 
> [...]

Applied, thanks!

[1/1] MAKEALL: query CONFIG_64BIT before make instead of CONFIG_ARM64 after
      https://git.pengutronix.de/cgit/barebox/commit/?id=181e6c5d638f (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>