From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Cc: jre@pengutronix.de
Subject: Re: [PATCH] FIT: compare key name hint with streq_ptr for clarity
Date: Mon, 20 Oct 2025 15:30:43 +0200 [thread overview]
Message-ID: <176096704376.2427672.12736056348766814563.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20251010054939.3067504-1-a.fatoum@barebox.org>
On Fri, 10 Oct 2025 07:49:33 +0200, Ahmad Fatoum wrote:
> When given a key name hint, we first attempt verification using the key
> it describes and fall through to verifying with all other keys.
>
> The code implementing this is not necessarily intuitive and strcmp()
> makes it harder to understand.
>
> As we check for NULL pointer anyway, let's use streq_ptr, which returns
> true instead of 0 on equality.
>
> [...]
Applied, thanks!
[1/1] FIT: compare key name hint with streq_ptr for clarity
https://git.pengutronix.de/cgit/barebox/commit/?id=3138d4988d33 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2025-10-20 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 5:49 Ahmad Fatoum
2025-10-10 8:45 ` Marco Felsch
2025-10-20 13:30 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176096704376.2427672.12736056348766814563.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
--cc=jre@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox