mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fixup! printf: define printk/no_printk in terms of prints
@ 2025-12-08 10:32 Ahmad Fatoum
  2025-12-08 12:12 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-12-08 10:32 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

printf: use printf instead of printk in no_printk

The original commit was decoupling them a bit to allow for implementing
a printk with Linux semantics. This also requires us that no_printf has
no dependency on printk, but that was missed. Add that now.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 include/printf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/printf.h b/include/printf.h
index 58793bc067dc..3503b72c9e5e 100644
--- a/include/printf.h
+++ b/include/printf.h
@@ -37,7 +37,7 @@ void __noreturn panic_no_stacktrace(const char *fmt, ...) __printf(1, 2);
 #define no_printf(fmt, ...)				\
 ({							\
 	if (0)						\
-		printk(fmt, ##__VA_ARGS__);		\
+		printf(fmt, ##__VA_ARGS__);		\
 	0;						\
 })
 
-- 
2.47.3




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fixup! printf: define printk/no_printk in terms of prints
  2025-12-08 10:32 [PATCH] fixup! printf: define printk/no_printk in terms of prints Ahmad Fatoum
@ 2025-12-08 12:12 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-12-08 12:12 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Mon, 08 Dec 2025 11:32:35 +0100, Ahmad Fatoum wrote:
> printf: use printf instead of printk in no_printk
> 
> The original commit was decoupling them a bit to allow for implementing
> a printk with Linux semantics. This also requires us that no_printf has
> no dependency on printk, but that was missed. Add that now.
> 
> 
> [...]

Applied, thanks!

[1/1] fixup! printf: define printk/no_printk in terms of prints
      https://git.pengutronix.de/cgit/barebox/commit/?id=e5a7137b3d1b (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-08 12:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-08 10:32 [PATCH] fixup! printf: define printk/no_printk in terms of prints Ahmad Fatoum
2025-12-08 12:12 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox