From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] efi: payload: don't fail postcore initcall when image has no device path
Date: Fri, 28 Aug 2026 14:13:30 +0200 [thread overview]
Message-ID: <178791921003.420855.6887607936040926348.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260826121510.2935211-1-a.fatoum@pengutronix.de>
On Wed, 26 Aug 2026 14:15:05 +0200, Ahmad Fatoum wrote:
> When barebox was loaded from memory or from a device without a device
> path, e.g. via QEMU's fw_cfg on top of the barebox EFI loader, the loaded
> image has no device handle. efi_postcore_init() currently bails out with
> -EINVAL in that case, printing an initcall error and skipping the
> registration of the barebox update handler.
>
> There is no partition UUID to export as LoaderDevicePartUUID then, but
> that's no reason to abort the initcall. The parent image handle may lack a
> device path as well, and device_path_to_filepath() would then crash on the
> NULL pointer. Make device_path_next_compatible_node() tolerate a NULL
> device path, so both helpers just return NULL and the initcall proceeds
> with the defaults.
>
> [...]
Applied, thanks!
[1/1] efi: payload: don't fail postcore initcall when image has no device path
https://git.pengutronix.de/cgit/barebox/commit/?id=da47299449f3 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-08-28 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 12:15 Ahmad Fatoum
2026-08-28 12:13 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178791921003.420855.6887607936040926348.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox