From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 28 Aug 2026 15:05:42 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wzwH7-008A8j-1d for lore@lore.pengutronix.de; Fri, 28 Aug 2026 15:05:42 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id 16F65201ED1 for ; Fri, 28 Aug 2026 15:05:42 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=1KxvNAX1; dmarc=none; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MmsUn63yOGKul42lCvU8OV9xYcE6KP50aw+PM+BEH1w=; b=1KxvNAX1ROacetXttqr7OjdQbO Vzfj2tCXs09BoaTLercK2wnVoE4KVWSZ3YreoD4MpEaLyAu6V4RFj30wEft5sl3g7LRavpxRPl2Yi NcXy997WFaFK9tkaGar4n7N2XRPMcHuFG0YUMEiDICOIvts0M2fSC+ukHA4Ish51JokQzPPu1bU/f WRiZ/y8nRcQm7D/hCbthiyw7RyVnPexiyNwsx2sqfg2g2fAEX4NPSlqSMi74DiF26mmbI8EOXhRwa comt0A/IoX+JRa0hMr5VBJZopsvBDUHw+YcU1eau/hSNnWR11nEmQgyz78BBjLm2PTeQIDTntAGCf KWtW8EMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzwG7-00000005mgV-15uO; Fri, 28 Aug 2026 13:04:39 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzwG5-00000005mfr-14Gp for barebox@lists.infradead.org; Fri, 28 Aug 2026 13:04:38 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 90364201ED1; Fri, 28 Aug 2026 15:04:35 +0200 (CEST) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wzwG3-003mDv-1f; Fri, 28 Aug 2026 15:04:35 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1wzwG3-00000001wJP-1tdP; Fri, 28 Aug 2026 15:04:35 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Ahmad Fatoum In-Reply-To: <20260825085316.1312263-1-a.fatoum@pengutronix.de> References: <20260825085316.1312263-1-a.fatoum@pengutronix.de> Subject: Re: [PATCH] efi: don't truncate EFI_MEMORY_RUNTIME when setting resource attributes Message-Id: <178792227544.462356.15698226183817906181.b4-ty@pengutronix.de> Date: Fri, 28 Aug 2026 15:04:35 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260828_060437_446597_9562F432 X-CRM114-Status: UNSURE ( 6.61 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Tue, 25 Aug 2026 10:53:15 +0200, Ahmad Fatoum wrote: > resource_set_efi_memory_type_attrs() stored the runtime attribute with > > res->runtime = attrs & EFI_MEMORY_RUNTIME; > > but struct resource [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Spamd-Result: default: False [-57.81 / 15.00]; RECEIVED_AUTHENTICATED_BY_MX1(-50.00)[]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; KNOWN_LIST_ID(-1.00)[barebox.lists.infradead.org]; RCVD_IN_DNSWL_MED(-0.60)[2a0a:edc0:0:c01:1d::a2:received,2a0a:edc0:0:1101:1d::28:received,2607:7c80:54:3::133:from]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; MAILLIST(-0.20)[mailman]; R_SPF_ALLOW(-0.20)[+mx:c]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[pengutronix.de]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; DKIM_TRACE(0.00)[lists.infradead.org:+]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; FROM_HAS_DN(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; NEURAL_HAM(-0.00)[-0.997]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Rspamd-Server: mx1 X-Stat-Signature: gbg3ehissm9a3jj8ranxqfaeizutu6hy X-Rspamd-Queue-Id: 16F65201ED1 On Tue, 25 Aug 2026 10:53:15 +0200, Ahmad Fatoum wrote: > resource_set_efi_memory_type_attrs() stored the runtime attribute with > > res->runtime = attrs & EFI_MEMORY_RUNTIME; > > but struct resource declares runtime as a one-bit field and > EFI_MEMORY_RUNTIME is bit 63, so the assignment keeps only the low bit of > the masked value and always stores zero. Every caller passing the > attribute silently ended up with a non-runtime resource. > > [...] Applied, thanks! [1/1] efi: don't truncate EFI_MEMORY_RUNTIME when setting resource attributes https://git.pengutronix.de/cgit/barebox/commit/?id=3177a7454bde (link may not be stable) Best regards, -- Sascha Hauer