From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 02 Sep 2026 10:30:49 +0200 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1gMq-009wa0-2u for lore@lore.pengutronix.de; Wed, 02 Sep 2026 10:30:49 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id 375CF205858 for ; Wed, 02 Sep 2026 10:30:49 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b="rbYPC/hT"; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nmn98haeAKTpc4PjzyyQQ0FIc86jjUpUpuWjfIrZdnM=; b=rbYPC/hTXrnuS03egGUHkcqzbt pAz9PBRIGKqtA8UrmS4mOjEdmzb7V8eqpZOvdEgcSpUiFXUQtlepuUJBm1Hu5OatIZ35Ep2Vayghl JuweeEixLRDIabSkpQ/lOb6AdDwTgut0u/bcbr2SWbuHEGqskUuynaCBdEq1qN8d9bxq9p3PFeIOx zo9m3jI7j6T7KdreZDku0ul77h5zq9A0NK+sz5xq9nPCy68HBd6pNZrMPDOcFXBbddLlL8y+Fqot6 qdaiO5FvtM/pIctrjhSOUZn+hTRI8KOGydejWBc1DfF4caGrOEODfO/1JfXRsCz8ZmUtlFBNw94eJ qA0uFnNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1gLk-0000000E5zR-0Dsa; Wed, 02 Sep 2026 08:29:40 +0000 Received: from mx1.white.stw.pengutronix.de ([185.203.200.13]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1gLh-0000000E5yv-2MD5 for barebox@lists.infradead.org; Wed, 02 Sep 2026 08:29:39 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id A14DF201865; Wed, 02 Sep 2026 10:29:35 +0200 (CEST) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1gLf-004Ynf-1s; Wed, 02 Sep 2026 10:29:35 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1x1gLf-0000000DImI-28SQ; Wed, 02 Sep 2026 10:29:35 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Alexander Shiyan In-Reply-To: <20260831120417.220684-1-eagle.alexander923@gmail.com> References: <20260831120417.220684-1-eagle.alexander923@gmail.com> Subject: Re: [PATCH] serial: ns16550: fix memory leak of linux_earlycon_name on probe failure Message-Id: <178833777550.3169901.17568115860157604842.b4-ty@pengutronix.de> Date: Wed, 02 Sep 2026 10:29:35 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260902_012937_822693_0C9D84D0 X-CRM114-Status: UNSURE ( 7.23 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 31 Aug 2026 15:04:17 +0300, Alexander Shiyan wrote: > When console_register() fails, the dynamically allocated > linux_earlycon_name string was not freed, leading to a memory leak. > Add a fr [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Rspamd-Queue-Id: 375CF205858 X-Spamd-Result: default: False [-57.81 / 15.00]; RECEIVED_AUTHENTICATED_BY_MX1(-50.00)[]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; KNOWN_LIST_ID(-1.00)[barebox.lists.infradead.org]; RCVD_IN_DNSWL_MED(-0.60)[2607:7c80:54:3::133:from,2a0a:edc0:0:c01:1d::a2:received,2a0a:edc0:0:1101:1d::28:received]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; MAILLIST(-0.20)[mailman]; R_SPF_ALLOW(-0.20)[+mx:c]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[lists.infradead.org,gmail.com]; ARC_NA(0.00)[]; DMARC_NA(0.00)[pengutronix.de]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; DKIM_TRACE(0.00)[lists.infradead.org:+]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; FROM_HAS_DN(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; NEURAL_HAM(-0.00)[-1.000]; TAGGED_RCPT(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Stat-Signature: gj18bq941inyn1iz6mhes6rw45fso7u8 X-Rspamd-Server: mx1 On Mon, 31 Aug 2026 15:04:17 +0300, Alexander Shiyan wrote: > When console_register() fails, the dynamically allocated > linux_earlycon_name string was not freed, leading to a memory leak. > Add a free_const() call on the error path to release it. > > Also simplify the success path by returning 0 directly after > successful registration, making the code more readable. > > [...] Applied, thanks! [1/1] serial: ns16550: fix memory leak of linux_earlycon_name on probe failure https://git.pengutronix.de/cgit/barebox/commit/?id=5e97fb61df43 (link may not be stable) Best regards, -- Sascha Hauer