From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 02 Sep 2026 10:33:04 +0200 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1gP1-009wbt-1s for lore@lore.pengutronix.de; Wed, 02 Sep 2026 10:33:04 +0200 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPS id 2C10620585C for ; Wed, 02 Sep 2026 10:33:04 +0200 (CEST) Authentication-Results: mx1.white.stw.pengutronix.de; dkim=pass header.d=lists.infradead.org header.s=bombadil.20210309 header.b=peXYstBG; spf=pass (mx1.white.stw.pengutronix.de: domain of "barebox-bounces+lore=pengutronix.de@lists.infradead.org" designates 2607:7c80:54:3::133 as permitted sender) smtp.mailfrom="barebox-bounces+lore=pengutronix.de@lists.infradead.org"; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Date:Message-Id:Subject:References:In-Reply-To:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LhkK4Y5w868Z/TKXPUVzWYk+frgtlRgAG1z0HN/5fq8=; b=peXYstBG1odGz0dnHDCFJOrCpA tqaCI3qJfmjScjeJkO0mlxatVH/n5FuxUyUvcF/jxT9nh6Fn2ZCmxLQFIrD/+lbw5ItUeHjmqQ9dE /r70881gJmpGn59MwfS3kCxx6hieaVqx6cGTs4aINdcYEoLVy/a0VlB+ZqHHvHLiCO2gb+TcHgyhf U1kS4trU2srbDDpETcnBq6jSMGg7nXWYQl8XTF96wjztmd4gzoBHHnwdqmDut2lNlBthy7jZ7VY7R OBq49UvnBOFQkrCDqAx1fmWEk4/FAPmTWUx8emvmilB8JsPevZAr2DwnnBuNpnaTuZmQ/jCPrHnF5 pnTHGPnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1gNy-0000000E6R1-1v2l; Wed, 02 Sep 2026 08:31:58 +0000 Received: from mx1.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::107]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1gNv-0000000E6QE-1Jjl for barebox@lists.infradead.org; Wed, 02 Sep 2026 08:31:57 +0000 Received: from drehscheibe.grey.stw.pengutronix.de (drehscheibe.grey.stw.pengutronix.de [IPv6:2a0a:edc0:0:c01:1d::a2]) (Authenticated sender: relay-from-drehscheibe.grey.stw.pengutronix.de) by mx1.white.stw.pengutronix.de (Postfix) with ESMTPSA id 1FD0F201DC9; Wed, 02 Sep 2026 10:31:53 +0200 (CEST) Received: from dude02.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::28]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1x1gNt-004YoB-0A; Wed, 02 Sep 2026 10:31:53 +0200 Received: from [::1] (helo=dude02.red.stw.pengutronix.de) by dude02.red.stw.pengutronix.de with esmtp (Exim 4.98.2) (envelope-from ) id 1x1gNs-0000000DcNh-4AX6; Wed, 02 Sep 2026 10:31:52 +0200 From: Sascha Hauer To: barebox@lists.infradead.org, Ahmad Fatoum In-Reply-To: <20260831144610.1034307-1-a.fatoum@pengutronix.de> References: <20260831144610.1034307-1-a.fatoum@pengutronix.de> Subject: Re: [PATCH] treewide: replace inappropriate printk Message-Id: <178833791299.3245669.7293119119244349862.b4-ty@pengutronix.de> Date: Wed, 02 Sep 2026 10:31:52 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.14.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260902_013155_505910_1F00233C X-CRM114-Status: UNSURE ( 7.32 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 31 Aug 2026 16:46:09 +0200, Ahmad Fatoum wrote: > In preparation for making printk loglevel-aware in the future, replace bare > printk in command handlers with printf, as it's user-facing out [...] Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 DMARC_MISSING Missing DMARC policy X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-Rspamd-Queue-Id: 2C10620585C X-Spamd-Result: default: False [-57.81 / 15.00]; RECEIVED_AUTHENTICATED_BY_MX1(-50.00)[]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[infradead.org:dkim]; KNOWN_LIST_ID(-1.00)[barebox.lists.infradead.org]; RCVD_IN_DNSWL_MED(-0.60)[2a0a:edc0:0:c01:1d::a2:received,2607:7c80:54:3::133:from,2a0a:edc0:0:1101:1d::28:received]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; MAILLIST(-0.20)[mailman]; R_SPF_ALLOW(-0.20)[+mx:c]; R_DKIM_ALLOW(-0.20)[lists.infradead.org:s=bombadil.20210309]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[pengutronix.de]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:7247, ipnet:2607:7c80:54::/48, country:US]; DKIM_TRACE(0.00)[lists.infradead.org:+]; RCVD_COUNT_FIVE(0.00)[5]; FROM_NEQ_ENVFROM(0.00)[s.hauer@pengutronix.de,barebox-bounces@lists.infradead.org]; FROM_HAS_DN(0.00)[]; TAGGED_FROM(0.00)[lore=pengutronix.de]; NEURAL_HAM(-0.00)[-1.000]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Action: no action X-Stat-Signature: jird8e3g4c18z1wd8m7eipx4ct6acz45 X-Rspamd-Server: mx1 On Mon, 31 Aug 2026 16:46:09 +0200, Ahmad Fatoum wrote: > In preparation for making printk loglevel-aware in the future, replace bare > printk in command handlers with printf, as it's user-facing output, > and in library code with pr_err/pr_warn to get proper log level annotations. > > Remaining instances of printk are mostly in driver code and will be fine > when we switch to logging instead of printf. > > [...] Applied, thanks! [1/1] treewide: replace inappropriate printk https://git.pengutronix.de/cgit/barebox/commit/?id=5b408765916b (link may not be stable) Best regards, -- Sascha Hauer