From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] virtio: fix out-of-bounds scatterlist array access in virtqueue_add_{in,out}buf
Date: Wed, 02 Sep 2026 10:32:32 +0200 [thread overview]
Message-ID: <178833795207.3269048.13450312551600632879.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20260831144746.1035711-1-a.fatoum@pengutronix.de>
On Mon, 31 Aug 2026 16:47:44 +0200, Ahmad Fatoum wrote:
> virtqueue_add_outbuf() and virtqueue_add_inbuf() take one scatterlist
> with N entries, but pass N to virtqueue_add_sgs() as the number of
> scatterlists, which then reads sgs[1] past the single pointer on the
> stack. In virtio_net_send(), GCC happened to place the zeroed
> virtio_net_hdr there, so the bogus entry was NULL and skipped. With
> clang it's the saved frame pointer:
>
> [...]
Applied, thanks!
[1/1] virtio: fix out-of-bounds scatterlist array access in virtqueue_add_{in,out}buf
https://git.pengutronix.de/cgit/barebox/commit/?id=24e609e61e5e (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-09-02 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 14:47 Ahmad Fatoum
2026-09-02 8:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178833795207.3269048.13450312551600632879.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox