From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Ahmad Fatoum <a.fatoum@barebox.org>
Subject: Re: [PATCH] of: reject alias values that are not NUL-terminated
Date: Tue, 20 Oct 2026 15:58:20 +0200 [thread overview]
Message-ID: <179250470041.2719444.4778620029729031174.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20261015140907.1275192-1-a.fatoum@pengutronix.de>
On Thu, 15 Oct 2026 16:08:59 +0200, Ahmad Fatoum wrote:
> of_alias_resolve() passes the value of an /aliases property straight
> to of_find_node_by_path_from() as a C string. Unflattened property
> values are copied with their exact length, so a value without a
> terminating NUL makes the path lookup read past the end of the
> allocation.
>
> Only devicetrees barebox trusts get here.
> Still, let's skip such values like libfdt's fdt_get_alias_namelen()
> does.
>
> [...]
Applied, thanks!
[1/1] of: reject alias values that are not NUL-terminated
https://git.pengutronix.de/cgit/barebox/commit/?id=68cda0c04a34 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-10-20 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 14:08 Ahmad Fatoum
2026-10-20 13:58 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179250470041.2719444.4778620029729031174.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox