From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@barebox.org>
Subject: Re: [PATCH] FIP: don't free the buffer twice when parsing fails
Date: Mon, 09 Nov 2026 10:07:35 +0100 [thread overview]
Message-ID: <179421525564.499899.16599620988285828074.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20261108201524.1400939-1-a.fatoum@barebox.org>
On Sun, 08 Nov 2026 21:15:23 +0100, Ahmad Fatoum wrote:
> fip_do_parse_buf() hands the buffer to the fip_state before it checks
> anything, so fip_free() frees it. fip_parse() freed it on a parse error
> as well, and fiptool and the bootm handler call fip_free() afterwards,
> which trips over the double free:
>
> !block_is_free(block) && "block already marked as free"common/tlsf.c 1069
>
> [...]
Applied, thanks!
[1/1] FIP: don't free the buffer twice when parsing fails
https://git.pengutronix.de/cgit/barebox/commit/?id=db380db7a860 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2026-11-09 10:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 20:15 Ahmad Fatoum
2026-11-09 9:07 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179421525564.499899.16599620988285828074.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox