From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] mci: sdhci: provide sdhci_readx_poll_timeout helpers
Date: Mon, 20 Apr 2020 08:25:37 +0200 [thread overview]
Message-ID: <1890d7dd-db55-8237-059a-be522b5c0d17@pengutronix.de> (raw)
In-Reply-To: <20200420062232.GB1694@pengutronix.de>
On 4/20/20 8:22 AM, Sascha Hauer wrote:
> On Wed, Apr 15, 2020 at 11:29:13AM +0200, Ahmad Fatoum wrote:
>> The sdhci_readN accessors don't lend themselves for clean use with
>> readx_poll_timeout because they accept two arguments. Add
>> a sdhci-specific helper, so the sdhci drivers can cut down on the
>> timeout loop boilerplate.
> Is this really an improvement? How many variants of these helpers will we get?
It's used 6 times within this series. Other SDHCI drivers can make use of it too.
Would you prefer extending <linux/iopoll.h> with a two arg accessor variant
instead?
Cheers,
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-04-20 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 9:29 Ahmad Fatoum
2020-04-15 9:29 ` [PATCH 2/4] mci: sdhci: implement sdhci_reset() Ahmad Fatoum
2020-04-15 9:29 ` [PATCH 3/4] ARM: at91: dts: specify aliases for sdmmc nodes Ahmad Fatoum
2020-04-15 9:29 ` [PATCH 4/4] mci: sdhci: add Atmel SDHCI (sama5d2, sam9x60) support Ahmad Fatoum
2020-04-20 6:22 ` [PATCH 1/4] mci: sdhci: provide sdhci_readx_poll_timeout helpers Sascha Hauer
2020-04-20 6:25 ` Ahmad Fatoum [this message]
2020-04-22 5:51 ` Sascha Hauer
2020-04-22 5:49 ` [PATCH 1/2] iopoll: Introduce read_poll_timeout Sascha Hauer
2020-04-22 5:49 ` [PATCH 2/2] mci: sdhci: provide sdhci_readx_poll_timeout helpers Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1890d7dd-db55-8237-059a-be522b5c0d17@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox