mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Clément Leger" <cleger@kalray.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] kvx: do not include empty <config.h>
Date: Fri, 15 May 2020 17:36:26 +0200 (CEST)	[thread overview]
Message-ID: <1973581334.3088460.1589556986486.JavaMail.zimbra@kalray.eu> (raw)
In-Reply-To: <20200515152215.146833-1-masahiroy@kernel.org>

----- On 15 May, 2020, at 17:22, Masahiro Yamada masahiroy@kernel.org wrote:

> <config.h> is per-board config file, which is only allowed for old
> boards.
> 
> For new boards, the top Makefile creates an empty include/config.h
> 
> kvx does not have config.h, so #include <config.h> is useless.
> 
> Also, remove meaningless board-$(CONFIG_GENERIC).

Hi Masahiro,

Thanks for spotting that.

FWIW:
Acked-By: Clement Leger <cleger@kalray.eu> 

Clément

> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> 
> arch/kvx/Makefile          | 2 --
> arch/kvx/cpu/barebox.lds.S | 1 -
> arch/kvx/cpu/start.S       | 1 -
> 3 files changed, 4 deletions(-)
> 
> diff --git a/arch/kvx/Makefile b/arch/kvx/Makefile
> index c97cff345..7abaed651 100644
> --- a/arch/kvx/Makefile
> +++ b/arch/kvx/Makefile
> @@ -2,8 +2,6 @@ KBUILD_DEFCONFIG := generic_defconfig
> 
> KBUILD_CPPFLAGS += -fno-strict-aliasing
> 
> -board-$(CONFIG_GENERIC) := generic
> -
> KALLSYMS += --symbol-prefix=_
> 
> ifeq ($(CROSS_COMPILE),)
> diff --git a/arch/kvx/cpu/barebox.lds.S b/arch/kvx/cpu/barebox.lds.S
> index 8d1944afb..bf92564cf 100644
> --- a/arch/kvx/cpu/barebox.lds.S
> +++ b/arch/kvx/cpu/barebox.lds.S
> @@ -3,7 +3,6 @@
>  * Copyright (C) 2019 Kalray Inc.
>  */
> 
> -#include <config.h>
> #include <asm/common.h>
> #include <asm/sys_arch.h>
> #include <asm-generic/barebox.lds.h>
> diff --git a/arch/kvx/cpu/start.S b/arch/kvx/cpu/start.S
> index a02900fb9..d90272c71 100644
> --- a/arch/kvx/cpu/start.S
> +++ b/arch/kvx/cpu/start.S
> @@ -3,7 +3,6 @@
>  * Copyright (C) 2019 Kalray Inc.
>  */
> 
> -#include <config.h>
> #include <linux/linkage.h>
> #include <asm/privilege.h>
> #include <asm/sys_arch.h>
> --
> 2.25.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-05-15 15:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 15:22 Masahiro Yamada
2020-05-15 15:36 ` Clément Leger [this message]
2020-05-18  6:18 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1973581334.3088460.1589556986486.JavaMail.zimbra@kalray.eu \
    --to=cleger@kalray.eu \
    --cc=barebox@lists.infradead.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox