From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 6.mo2.mail-out.ovh.net ([87.98.165.38]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEaOA-00047l-JO for barebox@lists.infradead.org; Fri, 23 Jan 2015 09:18:51 +0000 Received: from mail184.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo2.mail-out.ovh.net (Postfix) with SMTP id 9A7C0FFA464 for ; Fri, 23 Jan 2015 10:18:26 +0100 (CET) Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) From: Jean-Christophe PLAGNIOL-VILLARD In-Reply-To: <54C207DD.9060201@atmel.com> Date: Fri, 23 Jan 2015 17:18:05 +0800 Message-Id: <1A8441EE-39E2-4C69-AB34-C7B7D14412D1@jcrosoft.com> References: <1421739085-21150-1-git-send-email-voice.shen@atmel.com> <20150121094113.GF12209@pengutronix.de> <54BF7960.2010006@atmel.com> <5A604EAA-7AE3-4195-96A5-23A564655251@jcrosoft.com> <54C207DD.9060201@atmel.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: atmel: sama5d3xek: fix conflict between w1 and led To: Bo Shen Cc: barebox@lists.infradead.org > On Jan 23, 2015, at 4:35 PM, Bo Shen wrote: > > Hi J, > > On 01/23/2015 03:58 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >> >>> On Jan 21, 2015, at 6:03 PM, Bo Shen wrote: >>> >>> Hi J, >>> >>> On 01/21/2015 05:56 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>>> >>>>> On Jan 21, 2015, at 5:41 PM, Sascha Hauer wrote: >>>>> >>>>> On Tue, Jan 20, 2015 at 03:31:25PM +0800, Bo Shen wrote: >>>>>> As the 1-wire and LED d2 use the same pin (PE25) on the EK board. >>>>>> So, make LED enable only when the 1-wire is disabled. >>>>>> >>>>>> Signed-off-by: Bo Shen >>>>>> --- >>>>>> >>>>>> arch/arm/boards/sama5d3xek/init.c | 8 ++++++++ >>>>>> 1 file changed, 8 insertions(+) >>>>> >>>> >>>> On barebox this does not conflict >>> >>> As both use gpio mode, which will call gpio request, when LED try to request the same gpio, it will failed. So, the led d2 won't be successfully registered. >> >> Yes with the pinctrl driver >> >> but it will be a choice at defconfig level not C code >> >> if you enable both we need to put a warning at compiling time > > I don't find any good solution for this, can you provide one? Thanks. > >> and decide which one is more important because if you do not use the w1 you may do except to have both legs > > Actually, in code, no use for led d2, only d1 heart beat. > Will take a look next week Best Regards, J. >> >>> >>>> as we do not have multi task support >>>> >>>> Best Regards, >>>> J. >>>>> Applied, thanks >>>>> >>>>> Sascha >>>>> >>>>> >>>>> -- >>>>> Pengutronix e.K. | | >>>>> Industrial Linux Solutions | http://www.pengutronix.de/ | >>>>> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >>>>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >>>> >>> >>> Best Regards, >>> Bo Shen >> > > Best Regards, > Bo Shen > _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox