From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: more CONFIG oddities in the current barebox tree
Date: Mon, 21 Dec 2009 10:32:48 +0100 [thread overview]
Message-ID: <20091221093248.GT15126@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0912200705560.18199@localhost>
On Sun, Dec 20, 2009 at 07:08:02AM -0500, Robert P. J. Day wrote:
>
> here's a short list of Makefile CONFIG tests that test for
> non-existent CONFIG variables -- not strictly an error, just valueless
> and can be removed if there's no compelling reason to keep them. (as
> always, could be trivial false positives).
>
> ===== CMD_I2C =====
> ./commands/Makefile:obj-$(CONFIG_CMD_I2C) += i2c.o
This can be removed.
> ===== LOGO =====
> ./scripts/Makefile:hostprogs-$(CONFIG_LOGO) += pnmtologo
Ditto
> ===== MODULE =====
> ./common/Makefile:obj-$(CONFIG_MODULE) += module.o
> ./arch/ppc/Makefile:ifndef CONFIG_MODULE
Ditto. This is a duplicate of CONFIG_MODULES.
> ===== MODVERSIONS =====
> ./Makefile: KBUILD_BUILTIN := $(if $(CONFIG_MODVERSIONS),1)
> ./scripts/Makefile:#subdir-$(CONFIG_MODVERSIONS) += genksyms
> ===== PROM_CONSOLE =====
> ./scripts/Makefile:hostprogs-$(CONFIG_PROM_CONSOLE) += conmakehash
Can be removed.
> ===== SIMPLE_PARSER =====
> ./commands/Makefile:obj-$(CONFIG_SIMPLE_PARSER) += setenv.o
should be CONFIG_SHELL_SIMPLE instead.
> ===== USE_IRQ =====
> ./arch/ppc/mach-mpc5xxx/Makefile:obj-$(CONFIG_USE_IRQ) +=
> interrupts.o
> ./arch/ppc/lib/Makefile:obj-$(CONFIG_USE_IRQ) += interrupts.o
The IRQ stuff is an area for some more cleanup. So far I do not use
interrupts at all and I doubt they are working anywhere. Maybe it's best
to keep it like it is until somebody is willing to think about irqs and
has some suggestions in which direction we want to go.
> ===== VT =====
> ./scripts/Makefile:hostprogs-$(CONFIG_VT) += conmakehash
Can be removed.
>
> if any of that can be obviously deleted, let me know and i can
> submit the appropriate patches.
That would be great. Your scripts really put the eyes on some long
forgotten things ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2009-12-21 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 12:08 Robert P. J. Day
2009-12-21 9:32 ` Sascha Hauer [this message]
2009-12-21 9:37 ` Robert P. J. Day
2009-12-21 13:09 ` Robert P. J. Day
2009-12-21 13:27 ` Sascha Hauer
2009-12-21 13:56 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221093248.GT15126@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox