mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH] NAND: Free asprintf()-allocated space upon mtd device deletion.
Date: Mon, 21 Dec 2009 11:50:20 +0100	[thread overview]
Message-ID: <20091221105020.GZ15126@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0912210440490.11209@localhost>

On Mon, Dec 21, 2009 at 04:43:50AM -0500, Robert P. J. Day wrote:
> 
> Given that add_mtd_device() invokes asprintf() thusly:
> 
>   mtd->cdev.name = asprintf("nand%d", mtd->class_dev.id);
>   ...
>   mtd->param_size.value = asprintf("%u", mtd->size);
>   ...
>   mtd->cdev_oob.name = asprintf("nand_oob%d", mtd->class_dev.id);
> 
> make sure del_mtd_device() frees that in the reverse order.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

Ok, applied

Sascha

> 
> ---
> 
> diff --git a/drivers/nand/nand.c b/drivers/nand/nand.c
> index 0a6128c..bcf52bd 100644
> --- a/drivers/nand/nand.c
> +++ b/drivers/nand/nand.c
> @@ -240,7 +240,9 @@ int add_mtd_device(struct mtd_info *mtd)
>  int del_mtd_device (struct mtd_info *mtd)
>  {
>  	unregister_device(&mtd->class_dev);
> +	free(mtd->cdev_oob.name);
>  	free(mtd->param_size.value);
> +	free(mtd->cdev.name);
>  	return 0;
>  }
> 
> 
> ========================================================================
> Robert P. J. Day                               Waterloo, Ontario, CANADA
> 
>             Linux Consulting, Training and Kernel Pedantry.
> 
> Web page:                                          http://crashcourse.ca
> Twitter:                                       http://twitter.com/rpjday
> ========================================================================
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2009-12-21 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21  9:43 Robert P. J. Day
2009-12-21 10:50 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091221105020.GZ15126@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rpjday@crashcourse.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox