From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH] commands: Remove reference to non-existent CONFIG_CMD_I2C.
Date: Mon, 21 Dec 2009 12:30:52 +0100 [thread overview]
Message-ID: <20091221113052.GG15126@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0912210615350.13305@localhost>
On Mon, Dec 21, 2009 at 06:17:19AM -0500, Robert P. J. Day wrote:
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> the commands directory doesn't even have an i2c.c source file, so
> it's clearly safe to remove this reference. although i'm assuming
> that, at some point down the road, there will be an "i2c" command
> since that would be useful.
Ok, applied.
Is a i2c command really useful? For I2C eeproms you would create an
epprom driver which creates a file under /dev/ which you can then access
using the usual mm/mw commands.
Maybe an i2c command could be useful to register a new device on an I2C
bus.
Sascha
>
>
> diff --git a/commands/Makefile b/commands/Makefile
> index 134d8b3..1c657dd 100644
> --- a/commands/Makefile
> +++ b/commands/Makefile
> @@ -4,7 +4,6 @@ obj-$(CONFIG_CMD_LOADY) += loadb.o xyzModem.o
> obj-$(CONFIG_CMD_LOADS) += loads.o
> obj-$(CONFIG_CMD_ECHO) += echo.o
> obj-$(CONFIG_CMD_MEMORY) += mem.o
> -obj-$(CONFIG_CMD_I2C) += i2c.o
> obj-$(CONFIG_CMD_LOADS) += s_record.o
> obj-$(CONFIG_CMD_MTEST) += memtest.o
> obj-$(CONFIG_CMD_EDIT) += edit.o
>
> rday
> --
>
> ========================================================================
> Robert P. J. Day Waterloo, Ontario, CANADA
>
> Linux Consulting, Training and Kernel Pedantry.
>
> Web page: http://crashcourse.ca
> Twitter: http://twitter.com/rpjday
> ========================================================================
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2009-12-21 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-21 11:17 Robert P. J. Day
2009-12-21 11:30 ` Sascha Hauer [this message]
2009-12-21 11:33 ` Robert P. J. Day
2009-12-21 11:40 ` Peter Korsgaard
2009-12-21 11:47 ` Robert P. J. Day
2009-12-21 11:54 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091221113052.GG15126@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox