mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] EP93xx: Fix system controller register definitions
@ 2010-02-06 23:55 Matthias Kaehlcke
  2010-02-08 13:43 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Matthias Kaehlcke @ 2010-02-06 23:55 UTC (permalink / raw)
  To: barebox

EP93xx: The system controller register definition doesn't take into account a 4
byte gap between ChipId and SysCfg, in consequence all accesses to syscon registers
ahead of ChipId fail. Fix this by inserting a filler field

Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
---
 arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
index 50bb0eb..544f7f9 100644
--- a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
+++ b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
@@ -562,8 +562,9 @@ struct syscon_regs {
 	uint32_t i2sclkdiv;
 	uint32_t keytchclkdiv;
 	uint32_t chipid;
+	uint32_t reserved4;
 	uint32_t syscfg;
-	uint32_t reserved4[8];
+	uint32_t reserved5[8];
 	uint32_t sysswlock;
 };
 #else
-- 
1.6.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] EP93xx: Fix system controller register definitions
  2010-02-06 23:55 [PATCH] EP93xx: Fix system controller register definitions Matthias Kaehlcke
@ 2010-02-08 13:43 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2010-02-08 13:43 UTC (permalink / raw)
  To: Matthias Kaehlcke; +Cc: barebox

Hi Matthias,

On Sun, Feb 07, 2010 at 12:55:13AM +0100, Matthias Kaehlcke wrote:
> EP93xx: The system controller register definition doesn't take into account a 4
> byte gap between ChipId and SysCfg, in consequence all accesses to syscon registers
> ahead of ChipId fail. Fix this by inserting a filler field
> 
> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>

Your patches seem ok, I applied all three.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-08 13:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-06 23:55 [PATCH] EP93xx: Fix system controller register definitions Matthias Kaehlcke
2010-02-08 13:43 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox