mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] Fix compile time errors when DEBUG is defined
@ 2010-02-11 12:08 Juergen Beisert
  2010-02-12  7:31 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Juergen Beisert @ 2010-02-11 12:08 UTC (permalink / raw)
  To: barebox

If the DEBUG macro is defined the compiler complains about a missing
'ipu_base' variable.

Signed-off-by: Juergen Beisert <jbe@pengutronix.de>

diff --git a/drivers/video/imx-ipu-fb.c b/drivers/video/imx-ipu-fb.c
index 4a27009..0bd86b2 100644
--- a/drivers/video/imx-ipu-fb.c
+++ b/drivers/video/imx-ipu-fb.c
@@ -398,7 +398,7 @@ static inline u32 reg_read(struct ipu_fb_info *fbi, unsigned long reg)
 
 	val = readl(fbi->regs + reg);
 
-	debug("%s: %p 0x%08x\n", __func__, ipu_base + reg, val);
+	debug("%s: %p 0x%08x\n", __func__, fbi->regs + reg, val);
 
 	return val;
 }
@@ -406,7 +406,7 @@ static inline u32 reg_read(struct ipu_fb_info *fbi, unsigned long reg)
 static inline void reg_write(struct ipu_fb_info *fbi, u32 value,
 		unsigned long reg)
 {
-	debug("%s: %p 0x%08x\n", __func__, ipu_base + reg, value);
+	debug("%s: %p 0x%08x\n", __func__, fbi->regs + reg, value);
 
 	writel(value, fbi->regs + reg);
 }

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix compile time errors when DEBUG is defined
  2010-02-11 12:08 [PATCH] Fix compile time errors when DEBUG is defined Juergen Beisert
@ 2010-02-12  7:31 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2010-02-12  7:31 UTC (permalink / raw)
  To: Juergen Beisert; +Cc: barebox

On Thu, Feb 11, 2010 at 01:08:49PM +0100, Juergen Beisert wrote:
> If the DEBUG macro is defined the compiler complains about a missing
> 'ipu_base' variable.

Applied

Sascha

> 
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> 
> diff --git a/drivers/video/imx-ipu-fb.c b/drivers/video/imx-ipu-fb.c
> index 4a27009..0bd86b2 100644
> --- a/drivers/video/imx-ipu-fb.c
> +++ b/drivers/video/imx-ipu-fb.c
> @@ -398,7 +398,7 @@ static inline u32 reg_read(struct ipu_fb_info *fbi, unsigned long reg)
>  
>  	val = readl(fbi->regs + reg);
>  
> -	debug("%s: %p 0x%08x\n", __func__, ipu_base + reg, val);
> +	debug("%s: %p 0x%08x\n", __func__, fbi->regs + reg, val);
>  
>  	return val;
>  }
> @@ -406,7 +406,7 @@ static inline u32 reg_read(struct ipu_fb_info *fbi, unsigned long reg)
>  static inline void reg_write(struct ipu_fb_info *fbi, u32 value,
>  		unsigned long reg)
>  {
> -	debug("%s: %p 0x%08x\n", __func__, ipu_base + reg, value);
> +	debug("%s: %p 0x%08x\n", __func__, fbi->regs + reg, value);
>  
>  	writel(value, fbi->regs + reg);
>  }
> 
> -- 
> Pengutronix e.K.                              | Juergen Beisert             |
> Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
> Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-12  7:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-11 12:08 [PATCH] Fix compile time errors when DEBUG is defined Juergen Beisert
2010-02-12  7:31 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox