From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] i.MX35: Fix pad control bit positions
Date: Thu, 11 Feb 2010 16:01:47 +0100 [thread overview]
Message-ID: <201002111601.47675.jbe@pengutronix.de> (raw)
In-Reply-To: <201001291251.16655.jbe@pengutronix.de>
Hi Sascha,
as discussed at FOSDEM: *ping* ;-)
Juergen Beisert wrote:
> Using these macros simplify the configuration for special GPIO usage. But
> they should use correct bit positions for usage in the IOMUX_PAD() macro.
>
> Note: These are the bit positions of the i.MX35 CPU. Not checked for the
> other i.MX3x CPUs.
>
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
>
> ---
> arch/arm/mach-imx/include/mach/iomux-v3.h | 34
> +++++++++++++++--------------- 1 file changed, 17 insertions(+), 17
> deletions(-)
>
> Index: u-boot-v2/arch/arm/mach-imx/include/mach/iomux-v3.h
> ===================================================================
> --- u-boot-v2.orig/arch/arm/mach-imx/include/mach/iomux-v3.h
> +++ u-boot-v2/arch/arm/mach-imx/include/mach/iomux-v3.h
> @@ -68,25 +68,25 @@ struct pad_desc {
> /*
> * Use to set PAD control
> */
> -#define PAD_CTL_DRIVE_VOLTAGE_3_3_V 0
> -#define PAD_CTL_DRIVE_VOLTAGE_1_8_V 1
> +#define PAD_CTL_DRIVE_VOLTAGE_3_3_V (0)
> +#define PAD_CTL_DRIVE_VOLTAGE_1_8_V (1 << 13)
>
> -#define PAD_CTL_NO_HYSTERESIS 0
> -#define PAD_CTL_HYSTERESIS 1
> +#define PAD_CTL_NO_HYSTERESIS (0)
> +#define PAD_CTL_HYSTERESIS (1 << 8)
>
> -#define PAD_CTL_PULL_DISABLED 0x0
> -#define PAD_CTL_PULL_KEEPER 0xa
> -#define PAD_CTL_PULL_DOWN_100K 0xc
> -#define PAD_CTL_PULL_UP_47K 0xd
> -#define PAD_CTL_PULL_UP_100K 0xe
> -#define PAD_CTL_PULL_UP_22K 0xf
> -
> -#define PAD_CTL_OUTPUT_CMOS 0
> -#define PAD_CTL_OUTPUT_OPEN_DRAIN 1
> -
> -#define PAD_CTL_DRIVE_STRENGTH_NORM 0
> -#define PAD_CTL_DRIVE_STRENGTH_HIGH 1
> -#define PAD_CTL_DRIVE_STRENGTH_MAX 2
> +#define PAD_CTL_PULL_DISABLED (0)
> +#define PAD_CTL_PULL_KEEPER (0xa << 4)
> +#define PAD_CTL_PULL_DOWN_100K (0xc << 4)
> +#define PAD_CTL_PULL_UP_47K (0xd << 4)
> +#define PAD_CTL_PULL_UP_100K (0xe << 4)
> +#define PAD_CTL_PULL_UP_22K (0xf << 4)
> +
> +#define PAD_CTL_OUTPUT_CMOS (0)
> +#define PAD_CTL_OUTPUT_OPEN_DRAIN (1 << 3)
> +
> +#define PAD_CTL_DRIVE_STRENGTH_NORM (0)
> +#define PAD_CTL_DRIVE_STRENGTH_HIGH (1 << 1)
> +#define PAD_CTL_DRIVE_STRENGTH_MAX (2 << 1)
>
> #define PAD_CTL_SLEW_RATE_SLOW 0
> #define PAD_CTL_SLEW_RATE_FAST 1
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | Phone: +49-8766-939 228 |
Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-02-11 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 11:51 Juergen Beisert
2010-02-11 15:01 ` Juergen Beisert [this message]
2010-02-12 8:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002111601.47675.jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox