mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Fix compile time errors when DEBUG is defined
Date: Fri, 12 Feb 2010 08:31:15 +0100	[thread overview]
Message-ID: <20100212073115.GS17643@pengutronix.de> (raw)
In-Reply-To: <201002111308.50433.jbe@pengutronix.de>

On Thu, Feb 11, 2010 at 01:08:49PM +0100, Juergen Beisert wrote:
> If the DEBUG macro is defined the compiler complains about a missing
> 'ipu_base' variable.

Applied

Sascha

> 
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> 
> diff --git a/drivers/video/imx-ipu-fb.c b/drivers/video/imx-ipu-fb.c
> index 4a27009..0bd86b2 100644
> --- a/drivers/video/imx-ipu-fb.c
> +++ b/drivers/video/imx-ipu-fb.c
> @@ -398,7 +398,7 @@ static inline u32 reg_read(struct ipu_fb_info *fbi, unsigned long reg)
>  
>  	val = readl(fbi->regs + reg);
>  
> -	debug("%s: %p 0x%08x\n", __func__, ipu_base + reg, val);
> +	debug("%s: %p 0x%08x\n", __func__, fbi->regs + reg, val);
>  
>  	return val;
>  }
> @@ -406,7 +406,7 @@ static inline u32 reg_read(struct ipu_fb_info *fbi, unsigned long reg)
>  static inline void reg_write(struct ipu_fb_info *fbi, u32 value,
>  		unsigned long reg)
>  {
> -	debug("%s: %p 0x%08x\n", __func__, ipu_base + reg, value);
> +	debug("%s: %p 0x%08x\n", __func__, fbi->regs + reg, value);
>  
>  	writel(value, fbi->regs + reg);
>  }
> 
> -- 
> Pengutronix e.K.                              | Juergen Beisert             |
> Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
> Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2010-02-12  7:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 12:08 Juergen Beisert
2010-02-12  7:31 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100212073115.GS17643@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=jbe@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox