From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 01/12] ARM zImage: do memmap if possible
Date: Tue, 30 Mar 2010 14:18:01 +0200 [thread overview]
Message-ID: <20100330121801.GL2241@pengutronix.de> (raw)
In-Reply-To: <87r5n2b01l.fsf@macbook.be.48ers.dk>
On Tue, Mar 30, 2010 at 12:01:42PM +0200, Peter Korsgaard wrote:
> >>>>> "Sascha" == Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> Hi,
>
> >> Here you're rereading the header as well, instead of everything past
> >> it like the normal case.
>
> Sascha> Yes, mostly because I was too lazy to calculate the offsets.
>
> You could just have copied it from the line above ;)
>
> >> Does this give a significant boost? read() from something memmap'able
> >> (like NOR) boils down to a memcpy as well, right?
>
> Sascha> Hmm, with memmap it's 149ms and with read 156ms in my case. I
> Sascha> think this is because with memmap it goes down to a single
> Sascha> memcpy whereas with read we memcpy in chunks of 4k. I
> Sascha> implemented this out of reflex, but maybe it's really not worth
> Sascha> the added complexity.
>
> I imho don't think it's worth it. One of barebox' big advantages is how
> readable and clean the source code is.
Ok, I'll drop this patch.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-03-30 12:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 9:36 Patches for next merge window Sascha Hauer
2010-03-29 9:36 ` [PATCH 01/12] ARM zImage: do memmap if possible Sascha Hauer
2010-03-29 18:47 ` Peter Korsgaard
2010-03-30 9:20 ` Sascha Hauer
2010-03-30 10:01 ` Peter Korsgaard
2010-03-30 12:18 ` Sascha Hauer [this message]
2010-03-29 9:36 ` [PATCH 02/12] nand_imx: use optimized memcpy Sascha Hauer
2010-03-29 9:36 ` [PATCH 03/12] nand_imx: Speed up sequential read Sascha Hauer
2010-03-29 9:36 ` [PATCH 04/12] imx_nand: use memcpy for copying from/to buffer Sascha Hauer
2010-03-29 10:42 ` Ivo Clarysse
2010-03-29 9:36 ` [PATCH 05/12] add unaligned access support Sascha Hauer
2010-03-29 9:36 ` [PATCH 06/12] add unlzo support Sascha Hauer
2010-03-30 11:04 ` Sascha Hauer
2010-03-29 9:36 ` [PATCH 07/12] add snprintf function Sascha Hauer
2010-03-29 9:36 ` [PATCH 08/12] echo: add -e option support Sascha Hauer
2010-03-30 11:45 ` Peter Korsgaard
2010-03-30 12:17 ` Sascha Hauer
2010-03-29 9:36 ` [PATCH 09/12] add process_escape_sequence function Sascha Hauer
2010-03-29 9:36 ` [PATCH 10/12] echo command: Add -e option Sascha Hauer
2010-03-29 9:36 ` [PATCH 11/12] hush: only remove backslashes introduced from glob Sascha Hauer
2010-03-29 10:00 ` Sascha Hauer
2010-03-29 9:36 ` [PATCH 12/12] hush: allow fancy prompts Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100330121801.GL2241@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jacmet@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox