From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jan Weitzel <J.Weitzel@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fix miiphy alloc
Date: Wed, 14 Apr 2010 10:14:17 +0200 [thread overview]
Message-ID: <20100414081417.GI7882@pengutronix.de> (raw)
In-Reply-To: <1271232307.10496.14.camel@lws-weitzel>
Hi Jan,
On Wed, Apr 14, 2010 at 10:05:07AM +0200, Jan Weitzel wrote:
> if fec was allocated using malloc. if fec->miiphy->dev->driver != 0
> miiphy_probe is not called
Thanks, both applied.
Sascha
>
> Signed-off-by: Jan Weitzel <J.Weitzel@phytec.de>
> ---
> Index: barebox-2010.04.0/drivers/net/fec_imx.c
> ===================================================================
> --- barebox-2010.04.0.orig/drivers/net/fec_imx.c 2010-04-14 09:57:21.019441257 +0200
> +++ barebox-2010.04.0/drivers/net/fec_imx.c 2010-04-14 09:59:38.489396111 +0200
> @@ -542,10 +542,10 @@
> #ifdef CONFIG_ARCH_IMX27
> PCCR0 |= PCCR0_FEC_EN;
> #endif
> - edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
> - dev->type_data = edev;
> - fec = (struct fec_priv *)malloc(sizeof(*fec));
> - edev->priv = fec;
> + edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
> + dev->type_data = edev;
> + fec = (struct fec_priv *)xzalloc(sizeof(*fec));
> + edev->priv = fec;
> edev->open = fec_open,
> edev->init = fec_init,
> edev->send = fec_send,
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-04-14 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 8:05 Jan Weitzel
2010-04-14 8:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100414081417.GI7882@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=J.Weitzel@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox