[PATCH] fix miiphy alloc

[PATCH] fix miiphy alloc

[Jan Weitzel]

if fec was allocated using malloc. if fec->miiphy->dev->driver != 0
miiphy_probe is not called

Signed-off-by: Jan Weitzel <J.Weitzel@phytec.de>
---
Index: barebox-2010.04.0/drivers/net/fec_imx.c
===================================================================
--- barebox-2010.04.0.orig/drivers/net/fec_imx.c	2010-04-14 09:57:21.019441257 +0200
+++ barebox-2010.04.0/drivers/net/fec_imx.c	2010-04-14 09:59:38.489396111 +0200
@@ -542,10 +542,10 @@
 #ifdef CONFIG_ARCH_IMX27
 	PCCR0 |= PCCR0_FEC_EN;
 #endif
-        edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
-        dev->type_data = edev;
-	fec = (struct fec_priv *)malloc(sizeof(*fec));
-        edev->priv = fec;
+	edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
+	dev->type_data = edev;
+	fec = (struct fec_priv *)xzalloc(sizeof(*fec));
+	edev->priv = fec;
 	edev->open = fec_open,
 	edev->init = fec_init,
 	edev->send = fec_send,


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fix miiphy alloc

[Sascha Hauer]

Hi Jan,

On Wed, Apr 14, 2010 at 10:05:07AM +0200, Jan Weitzel wrote:
> if fec was allocated using malloc. if fec->miiphy->dev->driver != 0
> miiphy_probe is not called

Thanks, both applied.

Sascha

> 
> Signed-off-by: Jan Weitzel <J.Weitzel@phytec.de>
> ---
> Index: barebox-2010.04.0/drivers/net/fec_imx.c
> ===================================================================
> --- barebox-2010.04.0.orig/drivers/net/fec_imx.c	2010-04-14 09:57:21.019441257 +0200
> +++ barebox-2010.04.0/drivers/net/fec_imx.c	2010-04-14 09:59:38.489396111 +0200
> @@ -542,10 +542,10 @@
>  #ifdef CONFIG_ARCH_IMX27
>  	PCCR0 |= PCCR0_FEC_EN;
>  #endif
> -        edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
> -        dev->type_data = edev;
> -	fec = (struct fec_priv *)malloc(sizeof(*fec));
> -        edev->priv = fec;
> +	edev = (struct eth_device *)xzalloc(sizeof(struct eth_device));
> +	dev->type_data = edev;
> +	fec = (struct fec_priv *)xzalloc(sizeof(*fec));
> +	edev->priv = fec;
>  	edev->open = fec_open,
>  	edev->init = fec_init,
>  	edev->send = fec_send,
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox