mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] imx/gpio: make gpio_get_value actually work
Date: Fri, 23 Apr 2010 09:49:29 +0200	[thread overview]
Message-ID: <20100423074929.GZ7882@pengutronix.de> (raw)
In-Reply-To: <1272003760-15646-1-git-send-email-w.sang@pengutronix.de>

On Fri, Apr 23, 2010 at 08:22:40AM +0200, Wolfram Sang wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> The value read at the pin is provided by Sample Status Register, not the
> Data Register.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>

ok, applied to -next

Sascha

> ---
>  arch/arm/mach-imx/gpio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/gpio.c b/arch/arm/mach-imx/gpio.c
> index 6157bd1..c6a59a6 100644
> --- a/arch/arm/mach-imx/gpio.c
> +++ b/arch/arm/mach-imx/gpio.c
> @@ -121,7 +121,7 @@ int gpio_get_value(unsigned gpio)
>  	if (!base)
>  		return -EINVAL;
>  
> -	val = readl(base + GPIO_DR);
> +	val = readl(base + GPIO_PSR);
>  
>  	return val & (1 << shift) ? 1 : 0;
>  }
> -- 
> 1.7.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2010-04-23  7:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19  8:28 Patch series derived from latest project Wolfram Sang
     [not found] ` <1271665698-23163-7-git-send-email-w.sang@pengutronix.de>
2010-04-19  8:38   ` [PATCH 6/7] wip: fix possible error on overflow in is_timeout Uwe Kleine-König
     [not found]     ` <1271734752-8377-1-git-send-email-w.sang@pengutronix.de>
2010-04-22 11:32       ` [PATCH 6/7] clock: " Sascha Hauer
     [not found] ` <1271665698-23163-2-git-send-email-w.sang@pengutronix.de>
2010-04-22 11:10   ` [PATCH 1/7] give nice output when generating barebox.bin and barebox.S Sascha Hauer
2010-04-23  6:19     ` Wolfram Sang
2010-04-23  8:17     ` Uwe Kleine-König
     [not found] ` <1271665698-23163-3-git-send-email-w.sang@pengutronix.de>
2010-04-19  8:54   ` [PATCH 2/7] imx/gpio: make gpio_get_value actually work Uwe Kleine-König
2010-04-22 11:16   ` Sascha Hauer
     [not found]     ` <1272003760-15646-1-git-send-email-w.sang@pengutronix.de>
2010-04-23  7:49       ` Sascha Hauer [this message]
     [not found] ` <1271665698-23163-4-git-send-email-w.sang@pengutronix.de>
2010-04-22 11:31   ` [PATCH 3/7] arm: update mach-types Sascha Hauer
     [not found] ` <1271665698-23163-5-git-send-email-w.sang@pengutronix.de>
2010-04-22 11:31   ` [PATCH 4/7] cfi_flash: use flash_write_word instead of reimplementing it again Sascha Hauer
     [not found] ` <1271665698-23163-6-git-send-email-w.sang@pengutronix.de>
2010-04-22 11:31   ` [PATCH 5/7] board/pcm038: document value written to ESDCFG0 Sascha Hauer
     [not found] ` <1271665698-23163-8-git-send-email-w.sang@pengutronix.de>
2010-04-22 11:34   ` [PATCH 7/7] nor: Don't use the sector for the unlock sequence Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100423074929.GZ7882@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox