From: Sascha Hauer <s.hauer@pengutronix.de>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 09/17] pcm043: Speed up NAND controller before copying barebox image
Date: Mon, 3 May 2010 15:09:26 +0200 [thread overview]
Message-ID: <20100503130926.GC31199@pengutronix.de> (raw)
In-Reply-To: <87eihtdxzv.fsf@macbook.be.48ers.dk>
Hi Peter,
On Mon, May 03, 2010 at 01:29:40PM +0200, Peter Korsgaard wrote:
> >>>>> "Sascha" == Sascha Hauer <s.hauer@pengutronix.de> writes:
>
> Sascha> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Sascha> ---
> Sascha> board/pcm043/pcm043.c | 7 +++++++
> Sascha> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> Sascha> diff --git a/board/pcm043/pcm043.c b/board/pcm043/pcm043.c
> Sascha> index 2ce7e3a..d8cd7b8 100644
> Sascha> --- a/board/pcm043/pcm043.c
> Sascha> +++ b/board/pcm043/pcm043.c
> Sascha> @@ -393,6 +393,13 @@ BAREBOX_CMD_END
> Sascha> #ifdef CONFIG_NAND_IMX_BOOT
> Sascha> void __bare_init nand_boot(void)
> Sascha> {
> Sascha> + u32 val;
> Sascha> +
> Sascha> + val = readl(IMX_CCM_BASE + CCM_PDR4);
> Sascha> + val &= ~(0xf << 28);
> Sascha> + val |= 0x1 << 28;
> Sascha> + writel(val, IMX_CCM_BASE + CCM_PDR4);
>
> A comment describing what this does might be nice.
I dropped this patch since this is being touched in the reimplement-in-C
patch later anyway. The other patch also adds a comment.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-05-03 13:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 7:51 patches for next v2 Sascha Hauer
2010-04-29 7:51 ` [PATCH 01/17] i.MX35 stack: Fix mc9sdz60 reset register offset Sascha Hauer
2010-04-29 7:52 ` [PATCH 02/17] ARM: use memalign in dma_alloc_coherent to assure alignment Sascha Hauer
2010-04-29 7:52 ` [PATCH 03/17] fsl_udc: make it work with MMU on Sascha Hauer
2010-04-29 7:52 ` [PATCH 04/17] Increase MAX_FILES to 128 Sascha Hauer
2010-04-29 7:52 ` [PATCH 05/17] fix _update scripts Sascha Hauer
2010-04-29 7:52 ` [PATCH 06/17] define __LINUX_ARM_ARCH__ for armv6 processors Sascha Hauer
2010-04-29 7:52 ` [PATCH 07/17] ARM: Add get_cr/set_cr functions Sascha Hauer
2010-04-29 7:52 ` [PATCH 08/17] ARM: update icache functions to use get_cr/set_cr Sascha Hauer
2010-04-29 7:52 ` [PATCH 09/17] pcm043: Speed up NAND controller before copying barebox image Sascha Hauer
2010-05-03 11:29 ` Peter Korsgaard
2010-05-03 13:09 ` Sascha Hauer [this message]
2010-04-29 7:52 ` [PATCH 10/17] add arm helper function to determine the program counter Sascha Hauer
2010-04-29 7:52 ` [PATCH 11/17] arm: remove unused variables from header file Sascha Hauer
2010-04-29 7:52 ` [PATCH 12/17] arm: move __mmu_cache_flush to bare_init section Sascha Hauer
2010-04-29 7:52 ` [PATCH 13/17] arm: reimplement startup code in C Sascha Hauer
2010-04-29 7:52 ` [PATCH 14/17] i.MX: remove __REG from esd controller regs. use readl/writel instead Sascha Hauer
2010-04-29 7:52 ` [PATCH 15/17] pcm043: reimplement lowlevel code in C Sascha Hauer
2010-04-29 7:52 ` [PATCH 16/17] i.MX35: Fix ahbclock calculation Sascha Hauer
2010-04-29 7:52 ` [PATCH 17/17] pcm038: reimplement lowlevel code in C Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503130926.GC31199@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jacmet@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox