mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: V3 patches for imx35pdk boot
Date: Mon, 17 May 2010 11:04:16 +0200	[thread overview]
Message-ID: <20100517090416.GK31199@pengutronix.de> (raw)
In-Reply-To: <1273803319-24561-1-git-send-email-marc@cpdesign.com.au>

Hi Marc,

On Fri, May 14, 2010 at 12:15:14PM +1000, Marc Reilly wrote:
> Hi,
> 
> Third time's a charm, hopefully. I fixed up all the whitespace issues
> in 3stack.c and signed off all the patches.

There are still some trailing whitespaces left. I killed them while
committing.

> 
> The morale of the story is get it right first go :) (I'm not too sure
> how to combine patch 1 and 2, and being such a git newb my tree is
> already starting to look like a pair of octopi mating, so I'm just
> going to leave as is.)

Have a look at git rebase -i, it's really nice ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2010-05-17  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14  2:15 Marc Reilly
2010-05-14  2:15 ` [PATCH 1/5] arm: Add revision tag to boot parameters Marc Reilly
2010-05-14  2:15   ` [PATCH 2/5] arm boot: Formatting Marc Reilly
2010-05-14  2:15     ` [PATCH 3/5] imx35: add detection of silicon revision Marc Reilly
2010-05-14  2:15       ` [PATCH 4/5] imx35pdk: correct mode for display contrast pin Marc Reilly
2010-05-14  2:15         ` [PATCH 5/5] imx35pdk: Detect and set silicon and board revision for boot params Marc Reilly
2010-05-17  9:04 ` Sascha Hauer [this message]
2010-05-17 11:16   ` V3 patches for imx35pdk boot Marc Reilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517090416.GK31199@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=marc@cpdesign.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox