From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] drivers/nor: allow overriding of AMD_ADDR_* in board-configs
Date: Thu, 17 Jun 2010 10:54:04 +0200 [thread overview]
Message-ID: <20100617085404.GL20799@pengutronix.de> (raw)
In-Reply-To: <1276744965-994-1-git-send-email-w.sang@pengutronix.de>
On Thu, Jun 17, 2010 at 05:22:45AM +0200, Wolfram Sang wrote:
> Because there are a number of flash-makers who did it wrong.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
> drivers/nor/cfi_flash.h | 13 ++++++++++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/nor/cfi_flash.h b/drivers/nor/cfi_flash.h
> index a8fa879..a278772 100644
> --- a/drivers/nor/cfi_flash.h
> +++ b/drivers/nor/cfi_flash.h
> @@ -109,9 +109,16 @@ extern struct cfi_cmd_set cfi_cmd_set_amd;
> #define AMD_STATUS_TOGGLE 0x40
> #define AMD_STATUS_ERROR 0x20
>
> -#define AMD_ADDR_ERASE_START ((info->portwidth == FLASH_CFI_8BIT) ? 0xAAA : 0x555)
> -#define AMD_ADDR_START ((info->portwidth == FLASH_CFI_8BIT) ? 0xAAA : 0x555)
> -#define AMD_ADDR_ACK ((info->portwidth == FLASH_CFI_8BIT) ? 0x555 : 0x2AA)
> +/* AMD_ADDR_* can be overridden in board-specific config.h files */
> +#ifndef AMD_ADDR_ERASE_START
> +# define AMD_ADDR_ERASE_START ((info->portwidth == FLASH_CFI_8BIT) ? 0xAAA : 0x555)
> +#endif
> +#ifndef AMD_ADDR_START
> +# define AMD_ADDR_START ((info->portwidth == FLASH_CFI_8BIT) ? 0xAAA : 0x555)
> +#endif
> +#ifndef AMD_ADDR_ACK
> +# define AMD_ADDR_ACK ((info->portwidth == FLASH_CFI_8BIT) ? 0x555 : 0x2AA)
> +#endif
Uh, Having arbitrary board specific defines is exactly what I wanted to
get rid of while rewriting U-Boot. Sorry, this is not acceptable.
There are some ways to do this: You could add a runtime detection if
possible, maybe combined with a kconfig option if it influences image
size too badly. Or you could add the information to platform_data.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-06-17 8:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 3:22 Wolfram Sang
2010-06-17 8:54 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617085404.GL20799@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox