From: Sascha Hauer <s.hauer@pengutronix.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] envfs: fix build warning
Date: Thu, 24 Jun 2010 13:35:27 +0200 [thread overview]
Message-ID: <20100624113527.GA12115@pengutronix.de> (raw)
In-Reply-To: <20100624111917.GE27906@jasper.tkos.co.il>
On Thu, Jun 24, 2010 at 02:19:17PM +0300, Baruch Siach wrote:
> Hi Sascha,
>
> On Thu, Jun 24, 2010 at 01:10:30PM +0200, Sascha Hauer wrote:
> > On Thu, Jun 24, 2010 at 12:04:59PM +0300, Baruch Siach wrote:
> > > __LITTLE_ENDIAN or __BIG_ENDIAN are not always defined. E.g. the CodeSourcery
> > > G++ Lite 2010q1 for ARM (4.4.1) does not define __BIG_ENDIAN. This causes a
> > > compile time warning.
> >
> > Maybe we should rather define __LITTLE_ENDIAN and __BIG_ENDIAN
> > in include/linux/byteorder.h.
>
> You mean include/linux/byteorder/generic.h? I now see that __LITTLE_ENDIAN and
> __BIG_ENDIAN are defined in include/linux/byteorder/little_endian.h and
> include/linux/byteorder/big_endian.h respectively. Should we add their
> complement?
Yes.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-06-24 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 9:04 Baruch Siach
2010-06-24 11:10 ` Sascha Hauer
2010-06-24 11:19 ` Baruch Siach
2010-06-24 11:35 ` Sascha Hauer [this message]
2010-06-27 5:46 ` [PATCH] byteorder: add missing {BIG,LITTLE}_ENDIAN defines Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100624113527.GA12115@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=baruch@tkos.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox