mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync
Date: Wed, 4 Aug 2010 09:50:08 +0300	[thread overview]
Message-ID: <20100804065008.GC17208@jasper.tkos.co.il> (raw)
In-Reply-To: <1280888414-22759-1-git-send-email-plagnioj@jcrosoft.com>

Hi Jean-Christophe,

On Wed, Aug 04, 2010 at 04:20:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  include/init.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/init.h b/include/init.h
> index c5dea07..accc4d0 100644
> --- a/include/init.h
> +++ b/include/init.h
> @@ -1,6 +1,12 @@
>  #ifndef _INIT_H
>  #define _INIT_H
>  
> +/*
> + * fake define to simplify the linux sync
> + */
> +#define __init
> +#define __initdata
> +

IMO, having useless __init/__initdata in the code adds noise, and reduces 
readability.  These can be easily removed as code gets moved from Linux to 
Barebox.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-08-04  6:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04  2:20 Jean-Christophe PLAGNIOL-VILLARD
2010-08-04  6:50 ` Baruch Siach [this message]
2010-08-04 10:24   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100804065008.GC17208@jasper.tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox