From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync
Date: Wed, 4 Aug 2010 12:24:02 +0200 [thread overview]
Message-ID: <20100804102402.GA12545@game.jcrosoft.org> (raw)
In-Reply-To: <20100804065008.GC17208@jasper.tkos.co.il>
> >
> > +/*
> > + * fake define to simplify the linux sync
> > + */
> > +#define __init
> > +#define __initdata
> > +
>
> IMO, having useless __init/__initdata in the code adds noise, and reduces
> readability. These can be easily removed as code gets moved from Linux to
> Barebox.
but make impossible to apply patch directly or very quickly update the code
so this will make the job of maintainance easier
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-08-04 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 2:20 Jean-Christophe PLAGNIOL-VILLARD
2010-08-04 6:50 ` Baruch Siach
2010-08-04 10:24 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100804102402.GA12545@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=baruch@tkos.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox