mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Nishanth Menon <menon.nishanth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH|RFC] beagle: make nand ecc command based
Date: Wed, 18 Aug 2010 08:42:34 +0200	[thread overview]
Message-ID: <20100818064233.GY27749@pengutronix.de> (raw)
In-Reply-To: <4C6A6709.9080107@gmail.com>

On Tue, Aug 17, 2010 at 05:40:09AM -0500, Nishanth Menon wrote:
> On 08/17/2010 03:55 AM, Michael Grzeschik wrote:
>> Signed-off-by: Michael Grzeschik<m.grzeschik@pengutronix.de>
>> ---
>> This will only work once and bring the nand chip into a undefined state
>> after a second call. Any ideas for doing this save?
> looking at the gpmc logic, it does a reset in gpmc_cs_config by  
> disabling and re-enabling it -> so my guess is:
> a) in the selection of ecc logic
> b) reset of statemachines in mtd layers
> c) nand chip not being reset from it's previous state (resetting the  
> controller does not mean nand chip is reset) (if i recollect sometime  
> back mtd used to do a 0xff and reset)..
>
>
> personally, IMHO using s/w ecc has not much benefit other than being  
> "legacy enabled"

It really seems odd to me that the omap internal ROM code expects hw
ecc while xloader and kernel expect hw ecc. This way we always need
two different ecc algorithms in place which is really inconvenient and
hard for users to get it right.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-08-18  6:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  8:55 Michael Grzeschik
2010-08-17 10:40 ` Nishanth Menon
2010-08-18  6:42   ` Sascha Hauer [this message]
2010-08-18 10:03     ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100818064233.GY27749@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=menon.nishanth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox