mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/6] dm9000: allow to specify that no srom is present
Date: Thu, 19 Aug 2010 08:32:58 +0200	[thread overview]
Message-ID: <20100819063258.GC27749@pengutronix.de> (raw)
In-Reply-To: <1282186110-32738-1-git-send-email-plagnioj@jcrosoft.com>

Hi Jean-Christophe,

On Thu, Aug 19, 2010 at 04:48:25AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/boards/scb9328/scb9328.c |    1 +
>  drivers/net/dm9000.c              |    6 ++++--
>  include/dm9000.h                  |    1 +
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boards/scb9328/scb9328.c b/arch/arm/boards/scb9328/scb9328.c
> index e781393..3c04996 100644
> --- a/arch/arm/boards/scb9328/scb9328.c
> +++ b/arch/arm/boards/scb9328/scb9328.c
> @@ -55,6 +55,7 @@ static struct dm9000_platform_data dm9000_data = {
>  	.iobase   = 0x16000000,
>  	.iodata   = 0x16000004,
>  	.buswidth = DM9000_WIDTH_16,
> +	.srom     = 1;
>  };
>  
>  static struct device_d dm9000_dev = {
> diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
> index 2062c66..5f61ddc 100644
> --- a/drivers/net/dm9000.c
> +++ b/drivers/net/dm9000.c
> @@ -498,8 +498,10 @@ static int dm9000_probe(struct device_d *dev)
>  	edev->send = dm9000_eth_send;
>  	edev->recv = dm9000_eth_rx;
>  	edev->halt = dm9000_eth_halt;
> -	edev->get_ethaddr = dm9000_get_ethaddr;
> -	edev->set_ethaddr = dm9000_set_ethaddr;
> +	if (pdata->srom) {
> +		edev->get_ethaddr = dm9000_get_ethaddr;
> +		edev->set_ethaddr = dm9000_set_ethaddr;
> +	}

edev->set_ethaddr is not an optional call. Without it the driver won't
work.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-08-19  6:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19  2:48 [PATCH 0/6] AT91 fies and new soc & board Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  2:48 ` [PATCH 1/6] dm9000: allow to specify that no srom is present Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  6:32   ` Sascha Hauer [this message]
2010-08-19  6:40   ` [PATCH 1/6 v2] " Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  6:42     ` Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  2:48 ` [PATCH 2/6] at91: Introduction of at91sam9261 SOC Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  6:52   ` Sascha Hauer
2010-08-19 15:42     ` Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  2:48 ` [PATCH 3/6] at91: add Ronetix pm9261 board support Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  2:48 ` [PATCH 4/6] at91: rename clocksource.c -> at91sam926x_time.c Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  2:48 ` [PATCH 5/6] macb: introduce HAS_MACB configuration Jean-Christophe PLAGNIOL-VILLARD
2010-08-19  2:48 ` [PATCH 6/6] at91: remove non used and obsolete at91rm9200 code Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100819063258.GC27749@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox