Re: [PATCH] Add Menu Framework

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

> > > 
> > > - commands should always return positive error codes. A good practice is
> > >   to pass -E* values up to do_menu, use strerror() to print the error
> > >   code and return 1 afterwards.
> > I agree but but of the time there is no -E* related to this Framework
> > 
> > so do u want to create them?
> 
> No. The use of strerror might not be appropriate here, but all functions
> used should return some error value instead of -1, with -EINVAL as
> fallback when no better value can be found.
ok
> 
> > > 
> > > There is a 'break' missing here.
> > > 
> > fix
> > > > +			cm.action = action_add;
> > > > +			break;
> > > > +		case 'r':
> > > > +			cm.action = action_remove;
> > > > +			break;
> > > > +		case 'c':
> > > > +			cm.command = optarg;
> > > > +			break;
> > > 
> > > Thank you for this work. I really appreciate it ;)
> > Your welcome
> > My goal was to make the bootloader more easy to use for end user and
> > device without keyboard
> 
> Do you know openmoko? They also have a menu in U-Boot, but it's more or
> less hardcoded to their exact needs.
yeah I known, Denk force me to take a look at it when I send my patch to u-boot
ML but as you said everything is hardcoded and very limited
and for the record my code is NOT based on there work :)
so as I said him I do not like there stuff and think this one is as you said
flexible and simple

> > 
> > I plan to have this also via FrameBuffer and with a background image
> > so maybe barebox could replace grub & co aneday :)
> 
> A long way to go ;)
but a good target :-)

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox