From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/4] use resource_size_t for device ressoruces
Date: Fri, 27 Aug 2010 07:41:23 +0200 [thread overview]
Message-ID: <20100827054123.GC17521@pengutronix.de> (raw)
In-Reply-To: <1282886118-15217-4-git-send-email-plagnioj@jcrosoft.com>
Hello Jean-Christophe,
$SUBJECT ~= s/ressoruces/resources/
On Fri, Aug 27, 2010 at 07:15:18AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> include/driver.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/driver.h b/include/driver.h
> index ae3e777..eddbbf3 100644
> --- a/include/driver.h
> +++ b/include/driver.h
> @@ -70,11 +70,11 @@ struct device_d {
> int id;
>
> /*! FIXME */
What is this fixme about? Can it be removed?
> - unsigned long size;
> + resource_size_t size;
>
> /*! For devices which are directly mapped into memory, i.e. NOR
> * Flash or SDRAM. */
> - unsigned long map_base;
> + resource_size_t map_base;
>
> void *platform_data; /*! board specific information about this device */
>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-08-27 5:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 5:15 [PATCH 1/4] xfuncs.h: include linux/types.h to avoid non decleration of size_t Jean-Christophe PLAGNIOL-VILLARD
2010-08-27 5:15 ` [PATCH 2/4] introduce pure_initcall Jean-Christophe PLAGNIOL-VILLARD
2010-08-27 5:15 ` [PATCH 3/4] introduce phys_addr_t and resource_size_t Jean-Christophe PLAGNIOL-VILLARD
2010-08-27 5:15 ` [PATCH 4/4] use resource_size_t for device ressoruces Jean-Christophe PLAGNIOL-VILLARD
2010-08-27 5:41 ` Uwe Kleine-König [this message]
2010-08-27 5:56 ` [PATCH 4/4 v2] use resource_size_t for device resources Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827054123.GC17521@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox