mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] init: introduce __BARE_INIT for .section ".text_bare_init.text"
Date: Sun, 5 Sep 2010 19:12:26 +0200	[thread overview]
Message-ID: <20100905171226.GA3052@merkur.ravnborg.org> (raw)
In-Reply-To: <1283704919-26808-1-git-send-email-plagnioj@jcrosoft.com>

> diff --git a/include/init.h b/include/init.h
> index 8692b68..5a7a5b6 100644
> --- a/include/init.h
> +++ b/include/init.h
> @@ -7,6 +7,10 @@
>  #define __init
>  #define __initdata
>  
> +/* For assembly routines */
> +#define __BARE_INIT	.section ".text_bare_init.text"

You should consider using:
#define __BARE_INIT  .section ".text_bare_init.text","ax"

Then you do not rely on the as/ld to add these flags.
In the kernel we had a few cases where it mattered.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-09-05 17:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-05 16:41 Jean-Christophe PLAGNIOL-VILLARD
2010-09-05 17:12 ` Sam Ravnborg [this message]
2010-09-12 11:30 ` [PATCH v2] " Jean-Christophe PLAGNIOL-VILLARD
2010-09-16 10:56 ` [PATCH] " Sascha Hauer
2010-09-16 11:12   ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100905171226.GA3052@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox