mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 3/4] amba-pl011: probe fail if we can get the clock
Date: Sun, 12 Sep 2010 13:38:30 +0200	[thread overview]
Message-ID: <20100912113830.GM17771@game.jcrosoft.org> (raw)
In-Reply-To: <1284290860-32033-3-git-send-email-plagnioj@jcrosoft.com>

subject fix on git://git.jcrosoft.org/barebox.git sh-prepare

Best Regards,
J.
On 13:27 Sun 12 Sep     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  drivers/serial/amba-pl011.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c
> index 07508d0..8ddba2e 100644
> --- a/drivers/serial/amba-pl011.c
> +++ b/drivers/serial/amba-pl011.c
> @@ -34,6 +34,7 @@
>  #include <asm/io.h>
>  #include <linux/amba/serial.h>
>  #include <linux/clk.h>
> +#include <linux/err.h>
>  
>  /*
>   * We wrap our port structure around the generic console_device.
> @@ -160,6 +161,9 @@ static int pl011_probe(struct device_d *dev)
>  
>  	uart->clk = clk_get(dev, NULL);
>  
> +	if (PTR_ERR(uart->clk) < 0)
> +		return PTR_ERR(uart->clk);
> +
>  	cdev = &uart->uart;
>  	dev->type_data = cdev;
>  	cdev->dev = dev;
> -- 
> 1.7.1

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-09-12 11:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-12 11:27 [PATCH 1/4] driver: allow register device with specific id Jean-Christophe PLAGNIOL-VILLARD
2010-09-12 11:27 ` [PATCH 2/4] device: fix dev_name Jean-Christophe PLAGNIOL-VILLARD
2010-09-12 11:27 ` [PATCH 3/4] amba-pl011: probe fail if we can get the clock Jean-Christophe PLAGNIOL-VILLARD
2010-09-12 11:38   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2010-09-17 13:52     ` Sascha Hauer
2010-09-17 13:51   ` Sascha Hauer
2010-09-17 13:54     ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-12 11:27 ` [PATCH 4/4] stm8815: fix the uart device clock match Jean-Christophe PLAGNIOL-VILLARD
2010-09-17 13:45 ` [PATCH 1/4] driver: allow register device with specific id Sascha Hauer
2010-09-17 13:50   ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-17 13:54     ` Sascha Hauer
2010-09-17 13:55       ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100912113830.GM17771@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox