From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 29.mail-out.ovh.net ([87.98.216.213]) by bombadil.infradead.org with smtp (Exim 4.72 #1 (Red Hat Linux)) id 1OwbPp-0000ua-Cv for barebox@lists.infradead.org; Fri, 17 Sep 2010 13:55:50 +0000 Date: Fri, 17 Sep 2010 15:54:37 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20100917135437.GA21110@game.jcrosoft.org> References: <1284290860-32033-1-git-send-email-plagnioj@jcrosoft.com> <1284290860-32033-3-git-send-email-plagnioj@jcrosoft.com> <20100917135151.GE1473@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100917135151.GE1473@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 3/4] amba-pl011: probe fail if we can get the clock To: Sascha Hauer Cc: barebox@lists.infradead.org On 15:51 Fri 17 Sep , Sascha Hauer wrote: > Hi J, > > The subject should be '...fail if we can *not* get the clock'. yeah it's fix inthe pull request > > On Sun, Sep 12, 2010 at 01:27:39PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > > --- > > drivers/serial/amba-pl011.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c > > index 07508d0..8ddba2e 100644 > > --- a/drivers/serial/amba-pl011.c > > +++ b/drivers/serial/amba-pl011.c > > @@ -34,6 +34,7 @@ > > #include > > #include > > #include > > +#include > > > > /* > > * We wrap our port structure around the generic console_device. > > @@ -160,6 +161,9 @@ static int pl011_probe(struct device_d *dev) > > > > uart->clk = clk_get(dev, NULL); > > > > + if (PTR_ERR(uart->clk) < 0) > > We have the IS_ERR macro for testing. PTR_ERR is wrong here because it > only casts the pointer to long, so the condition above is true for every > pointer > 0x80000000. too Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox