mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Andre <armccurdy@gmail.com>
Subject: Re: [PATCH 2/2] sha1/sha256: use be32_to_cpu and cpu_to_be32
Date: Fri, 24 Sep 2010 10:34:38 +0200	[thread overview]
Message-ID: <20100924083438.GE16813@game.jcrosoft.org> (raw)
In-Reply-To: <20100924074303.GO23406@pengutronix.de>

On 09:43 Fri 24 Sep     , Sascha Hauer wrote:
> On Fri, Sep 24, 2010 at 12:00:42AM -0700, Andre wrote:
> > On 09/21/2010 06:28 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> >
> >> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD<plagnioj at jcrosoft.com>
> >> ---
> >>   lib/sha1.c   |   20 +++-----------------
> >>   lib/sha256.c |   19 +++----------------
> >>   2 files changed, 6 insertions(+), 33 deletions(-)
> >>
> >> diff --git a/lib/sha1.c b/lib/sha1.c
> >> index 0e8aed1..b4e2abc 100644
> >> --- a/lib/sha1.c
> >> +++ b/lib/sha1.c
> >> @@ -29,6 +29,7 @@
> >>   #include<digest.h>
> >>   #include<init.h>
> >>   #include<linux/string.h>
> >> +#include<asm/byteorder.h>
> >>
> >>   #define SHA1_SUM_POS	-0x20
> >>   #define SHA1_SUM_LEN	20
> >> @@ -44,23 +45,8 @@ sha1_context;
> >>   /*
> >>    * 32-bit integer manipulation macros (big endian)
> >>    */
> >> -#ifndef GET_UINT32_BE
> >> -#define GET_UINT32_BE(n,b,i) {				\
> >> -	(n) = ( (uint32_t) (b)[(i)    ]<<  24 )	\
> >> -	    | ( (uint32_t) (b)[(i) + 1]<<  16 )	\
> >> -	    | ( (uint32_t) (b)[(i) + 2]<<   8 )	\
> >> -	    | ( (uint32_t) (b)[(i) + 3]       );	\
> >> -}
> >> -#endif
> >> -
> >> -#ifndef PUT_UINT32_BE
> >> -#define PUT_UINT32_BE(n,b,i) {				\
> >> -	(b)[(i)    ] = (unsigned char) ( (n)>>  24 );	\
> >> -	(b)[(i) + 1] = (unsigned char) ( (n)>>  16 );	\
> >> -	(b)[(i) + 2] = (unsigned char) ( (n)>>   8 );	\
> >> -	(b)[(i) + 3] = (unsigned char) ( (n)       );	\
> >> -}
> >> -#endif
> >> +#define GET_UINT32_BE(n,b,i) (n) = be32_to_cpu(((uint32_t*)(b))[i / 4])
> >> +#define PUT_UINT32_BE(n,b,i) ((uint32_t*)(b))[i / 4] = cpu_to_be32(n)
> >>
> >>    
> >
> > The previous macros served two purposes: endian swapping and performing  
> > the memory accesses byte-by-byte. New versions are unsafe for CPUs which  
> > do not support misaligned 32bit memory accesses.
> 
> Indeed. We have get_unaligned_be32() / put_unaligned_be32(). These should be
> the correct functions, right?
no-nned IIRC as be32_to_cpu and cpu_to_be32 already handle this
depending on the arch

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2010-09-24  8:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 13:28 [PATCH 1/2] sha1: use unit32_t and uint8_t Jean-Christophe PLAGNIOL-VILLARD
2010-09-21 13:28 ` [PATCH 2/2] sha1/sha256: use be32_to_cpu and cpu_to_be32 Jean-Christophe PLAGNIOL-VILLARD
2010-09-24  7:00   ` Andre
2010-09-24  7:26     ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-24  7:43     ` Sascha Hauer
2010-09-24  8:34       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2010-09-24 10:16         ` Andre
2010-09-24 11:00           ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-24 11:15             ` Sascha Hauer
2010-09-24 11:43               ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-24 12:52                 ` Sascha Hauer
2010-09-24 12:56                   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924083438.GE16813@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=armccurdy@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox