From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] Fix default baudrate setting
Date: Mon, 27 Sep 2010 09:09:43 +0200 [thread overview]
Message-ID: <20100927070943.GU23406@pengutronix.de> (raw)
In-Reply-To: <4C9E8BBC.70103@pengutronix.de>
On Sun, Sep 26, 2010 at 01:54:36AM +0200, Marc Kleine-Budde wrote:
> On 09/25/2010 10:00 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 19:21 Sat 25 Sep , Juergen Beisert wrote:
> >> commit 604c99039f873952e252a5933309fc8e59b603db
> >> Author: Juergen Beisert <jbe@pengutronix.de>
> >> Date: Sat Sep 25 19:18:25 2010 +0200
> >>
> >> Fix default baudrate setting
> >>
> >> The menu entry to set the default baudrate (CONFIG_BAUDRATE) makes no sense,
> >> as long as its content is not used. This patch makes barebox using the setting
> >> again.
> >>
> >> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> >>
> >> diff --git a/common/console.c b/common/console.c
> >> index 204a08c..71fa88f 100644
> >> --- a/common/console.c
> >> +++ b/common/console.c
> >> @@ -140,9 +140,12 @@ int console_register(struct console_device *newcdev)
> >> dev->type_data = newcdev;
> >> register_device(dev);
> >>
> >> +#define xstr(s) str(s)
> >> +#define str(s) #s
> > can we put those macros in a more generic place?
>
> The kernel calls this stringify, see [1]
Ok, then we should add include/linux/stringify.h, remove the duplicate
in include/command.h and use stringify in this patch.
Sascha
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-09-27 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 17:21 Juergen Beisert
2010-09-25 20:00 ` Jean-Christophe PLAGNIOL-VILLARD
2010-09-25 23:54 ` Marc Kleine-Budde
2010-09-27 7:09 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927070943.GU23406@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox