From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 70.mail-out.ovh.net ([91.121.185.63]) by bombadil.infradead.org with smtp (Exim 4.72 #1 (Red Hat Linux)) id 1P1WLS-0002PG-Kv for barebox@lists.infradead.org; Fri, 01 Oct 2010 03:31:39 +0000 Date: Fri, 1 Oct 2010 05:29:54 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20101001032954.GD25320@game.jcrosoft.org> References: <1285903374-6825-1-git-send-email-marc@cpdesign.com.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1285903374-6825-1-git-send-email-marc@cpdesign.com.au> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] i2c-imx: wait for STOP before disabling controller To: Marc Reilly Cc: barebox@lists.infradead.org On 13:22 Fri 01 Oct , Marc Reilly wrote: > Makes sure that the STOP condition is transmitted before the I2C > controller is disabled. > This fixes a problem where writing to an external EEPROM was not working > because the EEPROM waits until the STOP before initiating the write > internally. > > Signed-off-by: Marc Reilly > --- > drivers/i2c/i2c-imx.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/i2c-imx.c b/drivers/i2c/i2c-imx.c > index cc64d94..3e37441 100644 > --- a/drivers/i2c/i2c-imx.c > +++ b/drivers/i2c/i2c-imx.c > @@ -265,7 +265,9 @@ static void i2c_imx_stop(struct i2c_adapter *adapter) > temp = readb(base + IMX_I2C_I2CR); > temp &= ~(I2CR_MSTA | I2CR_MTX); > writeb(temp, base + IMX_I2C_I2CR); > - i2c_imx->stopped = 1; > + /* wait for the stop condition to be send, otherwise the i2c > + * controller is disabled before the STOP is sent completely */ > + i2c_imx->stopped = i2c_imx_bus_busy(adapter,0) ? 0 : 1; please add a space after the "," Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox