Re: [PATCH v3] MAKEALL: make it generic

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3] MAKEALL: make it generic
Date: Fri, 1 Oct 2010 09:16:18 +0200	[thread overview]
Message-ID: <20101001071618.GA28242@pengutronix.de> (raw)
In-Reply-To: <1285903152-5840-1-git-send-email-plagnioj@jcrosoft.com>

On Fri, Oct 01, 2010 at 05:19:12AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> it's allow you to compile specific defconfig or ARCH or all
> as
> 
> CROSS_COMPILE=arm-linux- ARCH=arm ./MAKEALL at91sam9263ek_defconfig
> CROSS_COMPILE=arm-linux- ARCH=arm ./MAKEALL
> 
> The cross-compiler can be specify via
>     CROSS_COMPILE               default
>     CROSS_COMPILE_<arch>        arch default
>     CROSS_COMPILE_<target>      deconfig specifc
> 
> it will be evaluated in the invert order
> 
> or via config
> 
> you can specify it via env CONFIG or option -c (overwrite env)
> 
> CONFIG=./MAKEALL.cfg ARCH=arm ./MAKEALL at91sam9263ek_defconfig
> CONFIG=./MAKEALL.cfg ARCH=arm ./MAKEALL
> 
> and for all
> 
> CONFIG=./MAKEALL.cfg ./MAKEALL
> 
> you can specify via env or option
> env       option
> ARCH      -a      arch
> CONFIG    -c      config
> JOBS      -j      jobs
> BUILDDIR  -O      build dir
> LOGDIR    -l      log dir
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
> v3:
> add getopts supports
> 
> add usage support
> 
> Best Rebards,
> J.
>  MAKEALL |  286 ++++++++++++++++++++++++++++++++++++++++++++++++++-------------
>  1 files changed, 227 insertions(+), 59 deletions(-)
> 
> diff --git a/MAKEALL b/MAKEALL
> index dd0f66b..d42be6e 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -1,89 +1,257 @@
> -#!/bin/bash
> +#!/bin/sh

With /bin/sh here ./MAKEALL -c MAKEALL.cfg does not work. I have to
explicitely call ./MAKEALL -c ./MAKEALL.cfg. Can we keep /bin/bash here
or has anybody a better idea?

> +
> +if [ "${CONFIG}" ]
> +then
> +	source "${CONFIG}"
> +fi

It fails here with:

./MAKEALL: line 230: source: MAKEALL.cfg: file not found

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox