From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail9.tpgi.com.au ([203.12.160.104]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1P1Xhz-000417-RS for barebox@lists.infradead.org; Fri, 01 Oct 2010 04:59:00 +0000 From: Marc Reilly Date: Fri, 1 Oct 2010 14:58:24 +1000 References: <1285904458-7015-1-git-send-email-marc@cpdesign.com.au> <20101001042959.GE25320@game.jcrosoft.org> In-Reply-To: <20101001042959.GE25320@game.jcrosoft.org> MIME-Version: 1.0 Message-Id: <201010011458.24626.marc@cpdesign.com.au> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] imx: Internal boot sources, handle all header offsets To: Jean-Christophe PLAGNIOL-VILLARD Cc: barebox@lists.infradead.org Hi, > > -#define __image_len_0x100 __section(.image_len_0x100) > > +#if defined(CONFIG_ARCH_IMX_INTERNAL_BOOT_NOR) > > + #define __flash_header_section __section(.flash_header_0x1000) > > + #define __dcd_entry_section __section(.dcd_entry_0x1000) > > + #define __image_len_section __section(.image_len_0x1000) > > + #define FLASH_HEADER_OFFSET 0x1000 > > +#elif defined(CONFIG_ARCH_IMX_INTERNAL_BOOT_ONENAND) > > + #define __flash_header_section __section(.flash_header_0x0100) > > + #define __dcd_entry_section __section(.dcd_entry_0x0100) > > + #define __image_len_section __section(.image_len_0x0100) > > + #define FLASH_HEADER_OFFSET 0x0100 > > nor and onenand are the same why duplicate them? They look similar but, NOR offset is at 4Kb (0x1000), OneNand is 256b (0x100). (The leading zero for 0x0100 doesn't help, but is necessary otherwise the blah_0x1000 matches the blah_0x100* linker section.) Cheers Marc _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox