From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from 26.mail-out.ovh.net ([91.121.27.225]) by canuck.infradead.org with smtp (Exim 4.72 #1 (Red Hat Linux)) id 1P3KJk-0003Ui-Gt for barebox@lists.infradead.org; Wed, 06 Oct 2010 03:05:21 +0000 Date: Wed, 6 Oct 2010 05:03:24 +0200 From: Jean-Christophe PLAGNIOL-VILLARD Message-ID: <20101006030324.GA32214@game.jcrosoft.org> References: <20101005135213.24F871539A0@gemini.denx.de> <20101005160042.GI25320@game.jcrosoft.org> <20101005162019.GK25320@game.jcrosoft.org> <20101005175354.E53D21539A0@gemini.denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101005175354.E53D21539A0@gemini.denx.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: Code "borrowed" without attribution to original authors To: Wolfgang Denk Cc: barebox@lists.infradead.org On 19:53 Tue 05 Oct , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20101005162019.GK25320@game.jcrosoft.org> you wrote: > > > > > > d424ce7 image: factorise image printing contents > > > > 0ceafe1 Replace direct header access with the API routines > > > > > > aba80a2 image: rename IH_CPU to IH_ARCH to be more concistant > > > > 7bd7d59 image: factorise string helper > > for the record the two are not borrowed at all from U-Boot but done based on > > barebox > > Oh. Interesting statement. Let me check again. > > Your commit: > > commit aba80a2d2d0f1b25185246925577ce2108247dde > Author: Jean-Christophe PLAGNIOL-VILLARD > Date: Thu Sep 23 06:48:42 2010 +0200 > > image: rename IH_CPU to IH_ARCH to be more concistant > > So BB used to have IH_CPU and switched to IH_ARCH : > > Please compare against this U-Boot commit: > > commit b97a2a0a21f279d66de8a9bdbfe21920968bcb1c > Author: Marian Balakowicz > Date: Tue Jan 8 18:14:09 2008 +0100 > > [new uImage] Define a API for image handling operations > > - Add inline helper macros for basic header processing > - Move common non inline code common/image.c > - Replace direct header access with the API routines > - Rename IH_CPU_* to IH_ARCH_* > > Signed-off-by: Marian Balakowicz > > Pay special attention to the "Rename IH_CPU_* to IH_ARCH_*" part. > > Not borrowed? What an extremely unlikely coincidence then! I think > you should try to explain that. > > > and as we all known the uImage format come from U-Boot I just sync it > > recently without commit details as we do for Kconfig we do not trac > > modifications details and we respect the copyright. SO I'll repeat myself > > if Marian copyright is missing We will add it with pleasure. > > > I recommend you to get a clue about what is needed to properly > attribute code to the people who actually wrote it, instead of > submitting it without any due reference and then even claiming you > developed it yourself. I guess you are not interested in having a > reputation as a plagiarist? I'll repeat I'ev not borrow these two they look similar I agree but I do not borrow them. And I'm fine to put Marian copyright I eally do not carefor the other 2 commits. But these two I just had the same idea by looking at the code of barebox when I was working to re-introduce the mutli-image support. The two other commits are here for sync before finish the full sync of uImage and I will not take Marina work as mine. I'll put my SoB as I apply it and responsible for this integration as I did for kconfig and others without take the copyright. Best Regards, J. _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox