From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1P5JIO-0004la-Dn for barebox@lists.infradead.org; Mon, 11 Oct 2010 14:24:13 +0000 From: Juergen Beisert Date: Mon, 11 Oct 2010 16:22:14 +0200 References: <1286796505-16049-1-git-send-email-s.hauer@pengutronix.de> <201010111459.35914.jbe@pengutronix.de> <20101011135454.GZ28242@pengutronix.de> In-Reply-To: <20101011135454.GZ28242@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201010111622.15352.jbe@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 13/17] defaultenv: handle disk partitions To: barebox@lists.infradead.org Sascha Hauer wrote: > On Mon, Oct 11, 2010 at 02:59:35PM +0200, Juergen Beisert wrote: > > Sascha Hauer wrote: > > > On Mon, Oct 11, 2010 at 02:26:12PM +0200, Juergen Beisert wrote: > > > > Sascha Hauer wrote: > > > > > Signed-off-by: Sascha Hauer > > > > > --- > > > > > defaultenv/bin/init | 4 ++++ > > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git a/defaultenv/bin/init b/defaultenv/bin/init > > > > > index a55e8e6..526e3db 100644 > > > > > --- a/defaultenv/bin/init > > > > > +++ b/defaultenv/bin/init > > > > > @@ -8,6 +8,10 @@ if [ -e /dev/nor0 ]; then > > > > > addpart /dev/nor0 $nor_parts > > > > > fi > > > > > > > > > > +if [ -e /dev/disk0 ]; then > > > > > + addpart /dev/disk0 $disk_parts > > > > > +fi > > > > > + > > > > > > > > Are you sure you want/need additional partitions on a disk without a > > > > persistant partition table? > > > > > > No ;) > > > > > > It is not completely clear to me how we handle this best. On i.MX51 I > > > have some problems with the partition table. When booting from SD card > > > we just dump barebox.bin to the raw card. The partition table is then > > > part of barebox.bin. Unfortunately we do not know (or at least we don't > > > want to specifiy) the size of the card during compile time. > > > > > > How should a bootable SD card should be partitioned anyway? We could > > > add partitions for barebox/env/kernel/root like usual, but this does > > > not look very standard for SD cards (and we even need extended > > > partitions if we want to add a data partition). We could also add just > > > a single partition for root and maintain the rest outside of any > > > partition. > > > > If you want your kernel to work with this card you will need a partition > > table. Its more like a hard disk, not like a flash memory of NAND or NOR > > type. So, IMHO you will need a full blown partition table when you want > > use the SD card outside barebox. > > Yes I know. Do we need a fdisk command for barebox? IMHO not for barebox. Because to setup a full system on an SD card you would also need tools to create a filesystem on these partitions. That's not the job of a bootloader. We just have to handle partition tables in a correct manner. jbe -- Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | Phone: +49-8766-939 228 | Vertretung Sued/Muenchen, Germany | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de/ | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox