From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Eric Bénard" <eric@eukrea.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] cpuimx35: fix warning
Date: Thu, 21 Oct 2010 21:06:23 +0200 [thread overview]
Message-ID: <20101021190623.GG28242@pengutronix.de> (raw)
In-Reply-To: <1287582017-12999-2-git-send-email-eric@eukrea.com>
Hi Eric,
On Wed, Oct 20, 2010 at 03:40:16PM +0200, Eric Bénard wrote:
> this patch fix the following warning :
> arch/arm/boards/eukrea_cpuimx35/flash_header.c:30: warning: "DEST_BASE" redefined
> arch/arm/mach-imx/include/mach/imx-flash-header.h:29: note: this is the location of the previous definition
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> arch/arm/boards/eukrea_cpuimx35/flash_header.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boards/eukrea_cpuimx35/flash_header.c b/arch/arm/boards/eukrea_cpuimx35/flash_header.c
> index 4163caf..3133995 100644
> --- a/arch/arm/boards/eukrea_cpuimx35/flash_header.c
> +++ b/arch/arm/boards/eukrea_cpuimx35/flash_header.c
> @@ -27,6 +27,7 @@ struct imx_dcd_entry __dcd_entry_section dcd_entry[] = {
> { .ptr_type = 4, .addr = 0xb8001010, .val = 0x00000004, },
> };
>
> +#undef DEST_BASE
> #define DEST_BASE 0x80000000
> struct imx_flash_header __flash_header_section flash_header = {
> .app_code_jump_vector = DEST_BASE + 0x1000,
Why don't you just use another define instead of redefining DEST_BASE?
Grepping through the other boards there seems to be something wrong
here. The original idea was to let the rom code copy the image to the
address it is linked at to not have to relocate it later. This seems to
be not the case for most boards
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2010-10-21 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 13:40 [PATCH 1/3] fsl_udc: " Eric Bénard
2010-10-20 13:40 ` [PATCH 2/3] cpuimx35: " Eric Bénard
2010-10-21 19:06 ` Sascha Hauer [this message]
2010-10-21 20:40 ` Eric Bénard
2010-11-01 19:51 ` [PATCH] " Eric Bénard
2010-10-20 13:40 ` [PATCH 3/3] i.MX25 & 35 usb config bits : create mach/usb.h Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021190623.GG28242@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric@eukrea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox