From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by canuck.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1PJ1R4-0002pC-EY for barebox@lists.infradead.org; Thu, 18 Nov 2010 10:09:47 +0000 Date: Thu, 18 Nov 2010 11:09:43 +0100 From: Sascha Hauer Message-ID: <20101118100943.GV6017@pengutronix.de> References: <1288092708-5187-1-git-send-email-jbe@pengutronix.de> <20101101131946.GW6017@pengutronix.de> <201011151057.01538.jbe@pengutronix.de> <20101117084405.GR6017@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCHv2] Add dynamic video initialization to barebox To: Belisko Marek Cc: barebox@lists.infradead.org On Thu, Nov 18, 2010 at 09:18:36AM +0100, Belisko Marek wrote: > Hi, > = > On Wed, Nov 17, 2010 at 9:44 AM, Sascha Hauer wr= ote: > > On Mon, Nov 15, 2010 at 11:25:53AM +0100, Belisko Marek wrote: > >> Hi, > >> > >> On Mon, Nov 15, 2010 at 10:57 AM, Juergen Beisert = wrote: > >> > Hi Sascha, > >> > > >> > Sascha Hauer wrote: > >> >> On Tue, Oct 26, 2010 at 01:31:36PM +0200, Juergen Beisert wrote: > >> >> > Currently barebox uses a fixed videomode setup. Everything is com= piled > >> >> > in. This change adds the possibility to select a videomode accord= ing to a > >> >> > connected display at runtime. The current behaviour is still pres= ent if > >> >> > not otherwise configured. If configured for runtime setup, initia= lization > >> >> > of the video hardware will be delayed until the required videomod= e will > >> >> > be selected from the shell code. If more than one videomode is su= pported > >> >> > by the platform, running the 'devinfo' command on the framebuffer= device > >> >> > shows the supported videomode list. After selecting the videomode= , the > >> >> > output can be enabled. > >> >> > >> >> General remarks about this series: > >> >> > >> >> - Please do not add code with '#if 0' and activate it later. This s= hows > >> >> =A0 the series has the wrong order. > >> > > >> > This was for review only. If I would change the code in one step, th= e patch is > >> > unreadable. > >> > > >> >> - Please refrain from basing your internal functions around 'struct > >> >> =A0 device_d'. By doing so we completey lose type safety and at lea= st in > >> >> =A0 case of the mci framework where three different devices are inv= olved > >> >> =A0 this leads to unreadable and error prone code. > >> > > >> > But IMHO in the case of the MCI there _are_ three devices! > >> > =A0- The one that knows how to handle disk drives > >> > =A0- The one that knows what a SD card is > >> > =A0- the one that knows how to transfer data from an to an attached = device. > >> > > >> > Why this is unreadable or error prone? If you combine all these diff= erent > >> > functions into one I would say: Yes, the result is unreadable and er= ror > >> > prone. And if you would say for a bootloader this separate approach = is > >> > over-engineered, I would say: Maybe. > >> > > >> >> =A0 The framebuffer code should be based around struct fb_info. > >> > > >> > I do not like this idea, but okay. In the next series I will do it i= n this > >> > way. > >> > > >> >> - Please keep the line lengths within sensible limits. > >> > > >> > Sorry, I checked it the last time, but some lines are slipped throug= h. > >> Couldn't be included in barebox scripts also checkpatch.pl script from= kernel? > >> Would be nice to have proper patches with kernel coding style. > > > > Sure, send a patch ;) > Just checkpatch.pl from kernel or invent some less restrictive tool ;) > in e.g .python? checkpatch.pl should be fine. I won't require a patch to be checkpatch clean, but sometimes it's nice to be able to tell people 'go fix these checkpatch warnings' when there are obvious style problems in it. Sascha -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox