Re: [PATCH 1/5] device: introduce resource structure to simplify resource delaration

[Sascha Hauer <s.hauer@pengutronix.de>]

On Sun, Nov 21, 2010 at 05:28:54AM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 14:58 Sat 20 Nov     , Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 14:40 Sat 20 Nov     , Sascha Hauer wrote:
> > > On Fri, Nov 19, 2010 at 12:30:09PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > On 09:00 Fri 19 Nov     , Sascha Hauer wrote:
> > > > > Hi J,
> > > > > 
> > > > > On Fri, Nov 12, 2010 at 07:18:54PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > > > introdude also some helper to manager them
> > > > > > 
> > > > > > and add multi resource per device support
> > > > > > 
> > > > > > ram device: use resource structure instead of memory_platform_data
> > > > > > 
> > > > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > > 
> > > > > 
> > > > > You shouldn't use a resource_size_t type to access registers. This will
> > > > > lead to problems when we start to support 64bit resource sizes
> > > > no as resource_size_t is 64 bit aware
> > > 
> > > And exactly this is the problem. void * is usually only 32bit on arm.
> > > This will lead to compiler warnings and sparse isn't happy about
> > > unsigned long in readl/writel anyway.
> > IIRC on arm resource_size_t is never 64bit at least on the current ARMvx

Think of MMC/SD cards > 4G.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox