From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Juergen Beisert <jbe@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] STM/MCI: Fix wrong register bit
Date: Sun, 5 Dec 2010 11:50:28 +0100 [thread overview]
Message-ID: <20101205105028.GD10693@pengutronix.de> (raw)
In-Reply-To: <201012031459.50684.jbe@pengutronix.de>
On Fri, Dec 03, 2010 at 02:59:50PM +0100, Juergen Beisert wrote:
>
Maybe add something like: "The define isn't used up to now, so the wrong
offset didn't stick out before. For the same reason this fix isn't
critical." to the changelog?
Uwe
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> ---
> drivers/mci/stm378x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: barebox-git/drivers/mci/stm378x.c
> ===================================================================
> --- barebox-git.orig/drivers/mci/stm378x.c
> +++ barebox-git/drivers/mci/stm378x.c
> @@ -52,7 +52,7 @@
> # define SSP_CTRL0_SFTRST (1 << 31)
> # define SSP_CTRL0_CLKGATE (1 << 30)
> # define SSP_CTRL0_RUN (1 << 29)
> -# define SSP_CTRL0_LOCK_CS (1 << 29)
> +# define SSP_CTRL0_LOCK_CS (1 << 27)
> # define SSP_CTRL0_READ (1 << 25)
> # define SSP_CTRL0_IGNORE_CRC (1 << 26)
> # define SSP_CTRL0_DATA_XFER (1 << 24)
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2010-12-05 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 13:59 Juergen Beisert
2010-12-05 10:50 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101205105028.GD10693@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=jbe@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox